Fix supervisor content test validity defaults

Author: pallyoung

packages/web/src/features/supervisor/views/shared/objective-dialog-content.test.tsx

@@ -1,5 +1,6 @@
 import { fireEvent, render, screen, waitFor, within } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
+import type { ComponentProps } from "react";
 import { afterEach, describe, expect, it, vi } from "vitest";
 import { ObjectiveDialogContent } from "./objective-dialog-content";
 
@@ -26,65 +27,55 @@ afterEach(() => {
   delete (window as typeof window & { matchMedia?: typeof window.matchMedia }).matchMedia;
 });
 
+type ObjectiveDialogContentProps = ComponentProps<typeof ObjectiveDialogContent>;
+
+function createObjectiveDialogContentProps(
+  overrides: Partial<ObjectiveDialogContentProps> = {}
+): ObjectiveDialogContentProps {
+  return {
+    mode: "enable",
+    draftObjective: "Investigate regressions",
+    draftEvaluatorProviderId: "claude",
+    draftEvaluatorModel: "",
+    draftMaxSupervisionCount: "0",
+    draftScheduledAt: "",
+    isMaxSupervisionCountValid: true,
+    disableObjective: "",
+    onDraftObjectiveChange: vi.fn(),
+    onDraftEvaluatorProviderChange: vi.fn(),
+    onDraftEvaluatorModelChange: vi.fn(),
+    onDraftMaxSupervisionCountChange: vi.fn(),
+    onDraftScheduledAtChange: vi.fn(),
+    ...overrides,
+  };
+}
+
+function renderObjectiveDialogContent(overrides: Partial<ObjectiveDialogContentProps> = {}) {
+  return render(<ObjectiveDialogContent {...createObjectiveDialogContentProps(overrides)} />);
+}
+
 describe("ObjectiveDialogContent", () => {
-  it("does not render the supervisor intro strip by default for enable and edit modes", () => {
-    const { rerender } = render(
-      <ObjectiveDialogContent
-        mode="enable"
-        draftObjective="Investigate regressions"
-        draftEvaluatorProviderId="claude"
-        draftEvaluatorModel=""
-        draftMaxSupervisionCount="0"
-        draftScheduledAt=""
-        disableObjective=""
-        onDraftObjectiveChange={vi.fn()}
-        onDraftEvaluatorProviderChange={vi.fn()}
-        onDraftEvaluatorModelChange={vi.fn()}
-        onDraftMaxSupervisionCountChange={vi.fn()}
-        onDraftScheduledAtChange={vi.fn()}
-      />
+  it("renders the max supervision count field as valid by default in shared-content tests", () => {
+    renderObjectiveDialogContent();
+
+    expect(screen.getByLabelText("supervisor.field.max_supervision_count")).toHaveAttribute(
+      "aria-invalid",
+      "false"
     );
+  });
+
+  it("does not render the supervisor intro strip by default for enable and edit modes", () => {
+    const { rerender } = renderObjectiveDialogContent();
 
     expect(document.querySelector(".supervisor-dialog-intro")).toBeNull();
 
-    rerender(
-      <ObjectiveDialogContent
-        mode="edit"
-        draftObjective="Investigate regressions"
-        draftEvaluatorProviderId="claude"
-        draftEvaluatorModel=""
-        draftMaxSupervisionCount="0"
-        draftScheduledAt=""
-        disableObjective=""
-        onDraftObjectiveChange={vi.fn()}
-        onDraftEvaluatorProviderChange={vi.fn()}
-        onDraftEvaluatorModelChange={vi.fn()}
-        onDraftMaxSupervisionCountChange={vi.fn()}
-        onDraftScheduledAtChange={vi.fn()}
-      />
-    );
+    rerender(<ObjectiveDialogContent {...createObjectiveDialogContentProps({ mode: "edit" })} />);
 
     expect(document.querySelector(".supervisor-dialog-intro")).toBeNull();
   });
 
   it("renders a flat supervisor intro strip when showIntro is true for enable and edit modes", () => {
-    const { rerender } = render(
-      <ObjectiveDialogContent
-        mode="enable"
-        showIntro
-        draftObjective="Investigate regressions"
-        draftEvaluatorProviderId="claude"
-        draftEvaluatorModel=""
-        draftMaxSupervisionCount="0"
-        draftScheduledAt=""
-        disableObjective=""
-        onDraftObjectiveChange={vi.fn()}
-        onDraftEvaluatorProviderChange={vi.fn()}
-        onDraftEvaluatorModelChange={vi.fn()}
-        onDraftMaxSupervisionCountChange={vi.fn()}
-        onDraftScheduledAtChange={vi.fn()}
-      />
-    );
+    const { rerender } = renderObjectiveDialogContent({ showIntro: true });
 
     let intro = document.querySelector(".supervisor-dialog-intro");
     let introIcon = document.querySelector(".supervisor-dialog-intro__icon");
@@ -109,19 +100,7 @@ describe("ObjectiveDialogContent", () => {
 
     rerender(
       <ObjectiveDialogContent
-        mode="edit"
-        showIntro
-        draftObjective="Investigate regressions"
-        draftEvaluatorProviderId="claude"
-        draftEvaluatorModel=""
-        draftMaxSupervisionCount="0"
-        draftScheduledAt=""
-        disableObjective=""
-        onDraftObjectiveChange={vi.fn()}
-        onDraftEvaluatorProviderChange={vi.fn()}
-        onDraftEvaluatorModelChange={vi.fn()}
-        onDraftMaxSupervisionCountChange={vi.fn()}
-        onDraftScheduledAtChange={vi.fn()}
+        {...createObjectiveDialogContentProps({ mode: "edit", showIntro: true })}
       />
     );
 
@@ -148,22 +127,11 @@ describe("ObjectiveDialogContent", () => {
   });
 
   it("renders compact control classes instead of large form controls", () => {
-    render(
-      <ObjectiveDialogContent
-        mode="edit"
-        draftObjective="Investigate regressions"
-        draftEvaluatorProviderId="claude"
-        draftEvaluatorModel="sonnet"
-        draftMaxSupervisionCount="3"
-        draftScheduledAt=""
-        disableObjective=""
-        onDraftObjectiveChange={vi.fn()}
-        onDraftEvaluatorProviderChange={vi.fn()}
-        onDraftEvaluatorModelChange={vi.fn()}
-        onDraftMaxSupervisionCountChange={vi.fn()}
-        onDraftScheduledAtChange={vi.fn()}
-      />
-    );
+    renderObjectiveDialogContent({
+      mode: "edit",
+      draftEvaluatorModel: "sonnet",
+      draftMaxSupervisionCount: "3",
+    });
 
     const textarea = screen.getByLabelText("supervisor.field.objective");
     expect(textarea).toHaveClass("input", "textarea");
@@ -203,22 +171,11 @@ describe("ObjectiveDialogContent", () => {
   it("keeps objective editing behavior unchanged", () => {
     const onDraftObjectiveChange = vi.fn();
 
-    render(
-      <ObjectiveDialogContent
-        mode="enable"
-        draftObjective=""
-        draftEvaluatorProviderId="heuristic"
-        draftEvaluatorModel=""
-        draftMaxSupervisionCount="0"
-        draftScheduledAt=""
-        disableObjective=""
-        onDraftObjectiveChange={onDraftObjectiveChange}
-        onDraftEvaluatorProviderChange={vi.fn()}
-        onDraftEvaluatorModelChange={vi.fn()}
-        onDraftMaxSupervisionCountChange={vi.fn()}
-        onDraftScheduledAtChange={vi.fn()}
-      />
-    );
+    renderObjectiveDialogContent({
+      draftObjective: "",
+      draftEvaluatorProviderId: "heuristic",
+      onDraftObjectiveChange,
+    });
 
     const textarea = screen.getByLabelText("supervisor.field.objective");
     fireEvent.change(textarea, { target: { value: "Ship a safe rollout plan" } });
@@ -231,22 +188,10 @@ describe("ObjectiveDialogContent", () => {
     const user = userEvent.setup();
     const onDraftEvaluatorProviderChange = vi.fn();
 
-    render(
-      <ObjectiveDialogContent
-        mode="enable"
-        draftObjective=""
-        draftEvaluatorProviderId="claude"
-        draftEvaluatorModel=""
-        draftMaxSupervisionCount="0"
-        draftScheduledAt=""
-        disableObjective=""
-        onDraftObjectiveChange={vi.fn()}
-        onDraftEvaluatorProviderChange={onDraftEvaluatorProviderChange}
-        onDraftEvaluatorModelChange={vi.fn()}
-        onDraftMaxSupervisionCountChange={vi.fn()}
-        onDraftScheduledAtChange={vi.fn()}
-      />
-    );
+    renderObjectiveDialogContent({
+      draftObjective: "",
+      onDraftEvaluatorProviderChange,
+    });
 
     await user.click(screen.getByRole("button", { name: "supervisor.field.evaluator Claude" }));
 
@@ -268,22 +213,11 @@ describe("ObjectiveDialogContent", () => {
       (query) => query.includes("max-width: 899px") || query.includes("pointer: coarse")
     );
 
-    render(
-      <ObjectiveDialogContent
-        mode="enable"
-        draftObjective=""
-        draftEvaluatorProviderId="codex"
-        draftEvaluatorModel=""
-        draftMaxSupervisionCount="0"
-        draftScheduledAt=""
-        disableObjective=""
-        onDraftObjectiveChange={vi.fn()}
-        onDraftEvaluatorProviderChange={onDraftEvaluatorProviderChange}
-        onDraftEvaluatorModelChange={vi.fn()}
-        onDraftMaxSupervisionCountChange={vi.fn()}
-        onDraftScheduledAtChange={vi.fn()}
-      />
-    );
+    renderObjectiveDialogContent({
+      draftObjective: "",
+      draftEvaluatorProviderId: "codex",
+      onDraftEvaluatorProviderChange,
+    });
 
     const trigger = screen.getByRole("button", {
       name: "supervisor.field.evaluator Codex",
@@ -310,22 +244,16 @@ describe("ObjectiveDialogContent", () => {
     const onDraftMaxSupervisionCountChange = vi.fn();
     const onDraftScheduledAtChange = vi.fn();
 
-    render(
-      <ObjectiveDialogContent
-        mode="enable"
-        draftObjective=""
-        draftEvaluatorProviderId="codex"
-        draftEvaluatorModel="o3"
-        draftMaxSupervisionCount="5"
-        draftScheduledAt="2026-05-11T03:00"
-        disableObjective=""
-        onDraftObjectiveChange={vi.fn()}
-        onDraftEvaluatorProviderChange={vi.fn()}
-        onDraftEvaluatorModelChange={onDraftEvaluatorModelChange}
-        onDraftMaxSupervisionCountChange={onDraftMaxSupervisionCountChange}
-        onDraftScheduledAtChange={onDraftScheduledAtChange}
-      />
-    );
+    renderObjectiveDialogContent({
+      draftObjective: "",
+      draftEvaluatorProviderId: "codex",
+      draftEvaluatorModel: "o3",
+      draftMaxSupervisionCount: "5",
+      draftScheduledAt: "2026-05-11T03:00",
+      onDraftEvaluatorModelChange,
+      onDraftMaxSupervisionCountChange,
+      onDraftScheduledAtChange,
+    });
 
     fireEvent.change(screen.getByLabelText("supervisor.field.evaluator_model"), {
       target: { value: "gpt-5" },
@@ -339,23 +267,13 @@ describe("ObjectiveDialogContent", () => {
   });
 
   it("renders the semantic warning icon for disable mode", () => {
-    render(
-      <ObjectiveDialogContent
-        mode="disable"
-        showIntro
-        draftObjective=""
-        draftEvaluatorProviderId="codex"
-        draftEvaluatorModel=""
-        draftMaxSupervisionCount="0"
-        draftScheduledAt=""
-        disableObjective="Current objective"
-        onDraftObjectiveChange={vi.fn()}
-        onDraftEvaluatorProviderChange={vi.fn()}
-        onDraftEvaluatorModelChange={vi.fn()}
-        onDraftMaxSupervisionCountChange={vi.fn()}
-        onDraftScheduledAtChange={vi.fn()}
-      />
-    );
+    renderObjectiveDialogContent({
+      mode: "disable",
+      showIntro: true,
+      draftObjective: "",
+      draftEvaluatorProviderId: "codex",
+      disableObjective: "Current objective",
+    });
 
     expect(document.querySelector(".supervisor-dialog-intro")).toBeNull();
     expect(