fix(session): correct terminal_id in session_runtime_bindings

The terminal_id field in SessionRuntimeBindingInfo was incorrectly
set to runtime.runtime_id (e.g. "runtime:ws-1:session-1") instead of
runtime.terminal_id (the actual workspace terminal ID). This caused
the frontend's resolveAgentPaneTerminalBinding to set terminalId to the
runtime ID, which never matched any workspace terminal in the list.

Fix: use runtime.terminal_id for terminal_id, and only use
runtime.runtime_id for terminal_runtime_id.

Author: pallyoung

apps/server/src/command/http.rs

@@ -3499,7 +3499,8 @@ mod tests {
             .session_runtime_bindings
             .iter()
             .any(|binding| binding.session_id == "slot-primary"
-                && binding.terminal_id == started.terminal_runtime_id.clone().unwrap()
+                && binding.terminal_id == started.terminal_id.to_string()
+                && binding.terminal_runtime_id == started.terminal_runtime_id
                 && binding.workspace_terminal_id == Some(started.terminal_id.to_string())));
         assert!(observer
             .snapshot

apps/server/src/services/session_runtime.rs

@@ -155,15 +155,13 @@ pub(crate) fn collect_workspace_session_runtime_bindings(
         .iter()
         .filter_map(|(key, terminal_id)| {
             let session_id = key.strip_prefix(&prefix)?;
+            let runtime_info = runtime_registry.by_session(workspace_id, session_id);
             Some(SessionRuntimeBindingInfo {
                 session_id: session_id.to_string(),
-                terminal_id: runtime_registry
-                    .by_session(workspace_id, session_id)
-                    .map(|runtime| runtime.runtime_id.clone())
+                terminal_id: runtime_info
+                    .map(|runtime| runtime.terminal_id.to_string())
                     .unwrap_or_else(|| terminal_id.to_string()),
-                terminal_runtime_id: runtime_registry
-                    .by_session(workspace_id, session_id)
-                    .map(|runtime| runtime.runtime_id.clone()),
+                terminal_runtime_id: runtime_info.map(|runtime| runtime.runtime_id.clone()),
                 workspace_terminal_id: Some(terminal_id.to_string()),
             })
         })
@@ -789,7 +787,7 @@ mod tests {
         assert_eq!(bindings[0].terminal_runtime_id, result.terminal_runtime_id);
         assert_eq!(
             bindings[0].terminal_id,
-            bindings[0].terminal_runtime_id.clone().unwrap()
+            result.terminal_id.to_string()
         );
     }
 
@@ -863,7 +861,7 @@ mod tests {
         assert_eq!(bindings[0].session_id, session.id);
         assert_eq!(
             bindings[0].terminal_id,
-            result.terminal_runtime_id.clone().unwrap()
+            result.terminal_id.to_string()
         );
         assert_eq!(bindings[0].terminal_runtime_id, result.terminal_runtime_id);
         assert_eq!(