fix(web): tighten mobile terminal line-copy hit testing

Author: pallyoung

packages/web/src/features/terminal-panel/__tests__/xterm-host.test.tsx

@@ -7540,7 +7540,7 @@ describe("XtermHost", () => {
       expect.arrayContaining([
         expect.objectContaining({
           kind: "error",
-          title: "自动复制失败",
+          title: "当前行复制失败",
           body: "请重试长按当前行",
         }),
       ])

packages/web/src/features/terminal-panel/mobile/long-press-copy-line.test.ts

@@ -376,4 +376,59 @@ describe("getLogicalLineTextFromTouchPoint", () => {
 
     rows.remove();
   });
+
+  it("returns null when the touch point is inside a row band but outside the rendered text width", () => {
+    const { rows, secondRow } = createRowsDom();
+    const secondRowText = secondRow.querySelector("span span") as HTMLSpanElement | null;
+    document.body.appendChild(rows);
+    rows.getBoundingClientRect = () =>
+      ({
+        x: 20,
+        y: 100,
+        top: 100,
+        left: 20,
+        width: 320,
+        height: 60,
+        right: 340,
+        bottom: 160,
+        toJSON: () => ({}),
+      }) as DOMRect;
+    secondRow.getBoundingClientRect = () =>
+      ({
+        x: 20,
+        y: 120,
+        top: 120,
+        left: 20,
+        width: 320,
+        height: 20,
+        right: 340,
+        bottom: 140,
+        toJSON: () => ({}),
+      }) as DOMRect;
+    secondRowText!.getBoundingClientRect = () =>
+      ({
+        x: 20,
+        y: 120,
+        top: 120,
+        left: 20,
+        width: 80,
+        height: 20,
+        right: 100,
+        bottom: 140,
+        toJSON: () => ({}),
+      }) as DOMRect;
+
+    const terminal = createTerminal(70, [[71, createBufferLine("beta")]]);
+
+    expect(
+      getLogicalLineTextFromTouchPoint({
+        clientX: 180,
+        clientY: 130,
+        rowsElement: rows,
+        terminal,
+      })
+    ).toBeNull();
+
+    rows.remove();
+  });
 });

packages/web/src/features/terminal-panel/mobile/long-press-copy-line.ts

@@ -21,6 +21,21 @@ export interface GetLogicalLineTextFromTouchPointArgs {
   terminal: TerminalLikeForLongPressCopy;
 }
 
+function getRenderedTextBounds(rowElement: HTMLElement): { left: number; right: number } | null {
+  const spanRects = Array.from(rowElement.querySelectorAll("span"))
+    .map((span) => span.getBoundingClientRect())
+    .filter((rect) => rect.width > 0 && rect.height > 0);
+
+  if (spanRects.length === 0) {
+    return null;
+  }
+
+  return {
+    left: Math.min(...spanRects.map((rect) => rect.left)),
+    right: Math.max(...spanRects.map((rect) => rect.right)),
+  };
+}
+
 function getVisualRowIndexFromTouchPoint(
   rowsElement: HTMLElement,
   clientX: number,
@@ -40,8 +55,16 @@ function getVisualRowIndexFromTouchPoint(
     (child): child is HTMLElement => child instanceof HTMLElement
   );
   for (let index = 0; index < rowElements.length; index += 1) {
-    const rowRect = rowElements[index].getBoundingClientRect();
-    if (clientY >= rowRect.top && clientY <= rowRect.bottom) {
+    const rowElement = rowElements[index];
+    const rowRect = rowElement.getBoundingClientRect();
+    if (clientY < rowRect.top || clientY > rowRect.bottom) {
+      continue;
+    }
+
+    const renderedTextBounds = getRenderedTextBounds(rowElement);
+    const left = renderedTextBounds?.left ?? rowRect.left;
+    const right = renderedTextBounds?.right ?? rowRect.right;
+    if (clientX >= left && clientX <= right) {
       return index;
     }
   }

packages/web/src/features/terminal-panel/views/shared/xterm-host.tsx

@@ -885,7 +885,10 @@ export function XtermHost({
     lastCopyOnSelectFailureAtRef.current = now;
     pushToast({
       kind: "error",
-      title: t("settings.copy_on_select_failed_title"),
+      title:
+        viewport === "mobile"
+          ? t("terminal.mobile_copy_current_line_failed_title")
+          : t("settings.copy_on_select_failed_title"),
       body:
         viewport === "mobile"
           ? t("terminal.mobile_copy_current_line_failed_body")

packages/web/src/locales/en.json

@@ -260,6 +260,7 @@
     "create_unavailable_title": "No workspace selected",
     "create_unavailable_body": "Open or switch to a workspace before creating a terminal.",
     "copied_current_line": "Copied current line",
+    "mobile_copy_current_line_failed_title": "Current line copy failed",
     "mobile_copy_current_line_failed_body": "Try long-pressing the current line again",
     "hide": "Hide Terminal",
     "show": "Show Terminal",

packages/web/src/locales/zh.json

@@ -260,6 +260,7 @@
     "create_unavailable_title": "当前没有已选中的工作区",
     "create_unavailable_body": "请先打开或切换到一个工作区，再新建终端。",
     "copied_current_line": "已复制当前行",
+    "mobile_copy_current_line_failed_title": "当前行复制失败",
     "mobile_copy_current_line_failed_body": "请重试长按当前行",
     "hide": "隐藏终端",
     "show": "显示终端",