fix: drop supervisor repo targetId input

Author: pallyoung

packages/server/src/__tests__/supervisor-manager.test.ts

@@ -394,6 +394,21 @@ describe("SupervisorManager cycle triggers", () => {
     expect(deps.supervisorRepo.getBySessionId("sess-create-fails")).toBeUndefined();
   });
 
+  it("does not pass targetId into supervisor repo create", async () => {
+    await manager.create({
+      sessionId: "sess-create-shape",
+      workspaceId: "ws-1",
+      objective: "Ship the fix",
+      evaluatorProviderId: "codex",
+    });
+
+    expect(deps.supervisorRepo.create).toHaveBeenCalledWith(
+      expect.not.objectContaining({
+        targetId: expect.anything(),
+      })
+    );
+  });
+
   it("returns an in-flight cycle immediately on manual triggerEvaluation", async () => {
     const supervisor = await manager.create({
       sessionId: "sess-manual",

packages/server/src/__tests__/supervisor-repo.test.ts

@@ -46,7 +46,6 @@ describe("SupervisorRepo", () => {
       id: "sup-1",
       sessionId: "sess-1",
       workspaceId: "ws-1",
-      targetId: "target-1",
       state: "idle",
       objective: "Finish supervisor persistence",
       evaluatorProviderId: "codex",
@@ -65,7 +64,6 @@ describe("SupervisorRepo", () => {
       id: "sup-1",
       sessionId: "sess-1",
       workspaceId: "ws-1",
-      targetId: "target-initial",
       state: "stopped",
       objective: "Stop when objective is complete",
       evaluatorProviderId: "codex",
@@ -89,12 +87,11 @@ describe("SupervisorRepo", () => {
     });
   });
 
-  it("derives targetId from supervisor id and ignores targetId patches", () => {
+  it("derives targetId from supervisor id", () => {
     supervisorRepo.create({
       id: "sup-1",
       sessionId: "sess-1",
       workspaceId: "ws-1",
-      targetId: "target-alpha",
       state: "idle",
       objective: "Track target scope",
       evaluatorProviderId: "codex",
@@ -106,7 +103,7 @@ describe("SupervisorRepo", () => {
     expect(created?.targetId).toBe("sup-1");
 
     const updated = supervisorRepo.update("sup-1", {
-      targetId: "target-beta",
+      objective: "Track target scope again",
       updatedAt: 11,
     });
 
@@ -130,7 +127,6 @@ describe("SupervisorRepo", () => {
         id: "sup-bad",
         sessionId: "sess-2",
         workspaceId: "ws-1",
-        targetId: "target-bad",
         state: "idle",
         objective: "This insert must fail",
         evaluatorProviderId: "claude",
@@ -152,7 +148,6 @@ describe("SupervisorRepo", () => {
       id: "sup-1",
       sessionId: "sess-1",
       workspaceId: "ws-1",
-      targetId: "target-1",
       state: "idle",
       objective: "Enforce supervisor/session integrity",
       evaluatorProviderId: "claude",
@@ -181,7 +176,6 @@ describe("SupervisorRepo", () => {
       id: "sup-1",
       sessionId: "sess-1",
       workspaceId: "ws-1",
-      targetId: "target-1",
       state: "idle",
       objective: "Keep nullable fields intact",
       evaluatorProviderId: "claude",
@@ -208,7 +202,6 @@ describe("SupervisorRepo", () => {
       id: "sup-1",
       sessionId: "sess-1",
       workspaceId: "ws-1",
-      targetId: "target-1",
       state: "idle",
       objective: "Clear nullable fields",
       evaluatorProviderId: "claude",
@@ -236,7 +229,6 @@ describe("SupervisorRepo", () => {
       id: "sup-1",
       sessionId: "sess-1",
       workspaceId: "ws-1",
-      targetId: "target-1",
       state: "idle",
       objective: "Clear execution policy fields",
       evaluatorProviderId: "claude",
@@ -268,7 +260,6 @@ describe("SupervisorRepo", () => {
       id: "sup-1",
       sessionId: "sess-1",
       workspaceId: "ws-1",
-      targetId: "target-1",
       state: "idle",
       objective: "Keep cycle fields intact",
       evaluatorProviderId: "claude",
@@ -309,7 +300,6 @@ describe("SupervisorRepo", () => {
       id: "sup-1",
       sessionId: "sess-1",
       workspaceId: "ws-1",
-      targetId: "target-1",
       state: "idle",
       objective: "Clear cycle fields",
       evaluatorProviderId: "claude",
@@ -370,7 +360,6 @@ describe("SupervisorRepo", () => {
       id: "sup-1",
       sessionId: "sess-1",
       workspaceId: "ws-1",
-      targetId: "target-1",
       state: "idle",
       objective: "Keep the newest 100 cycles",
       evaluatorProviderId: "claude",
@@ -406,7 +395,6 @@ describe("SupervisorRepo", () => {
       id: "sup-1",
       sessionId: "sess-1",
       workspaceId: "ws-1",
-      targetId: "target-1",
       state: "idle",
       objective: "Allow scheduled cancelled cycle",
       evaluatorProviderId: "claude",
@@ -435,7 +423,6 @@ describe("SupervisorRepo", () => {
       id: "sup-1",
       sessionId: "sess-1",
       workspaceId: "ws-1",
-      targetId: "target-1",
       state: "idle",
       objective: "Track attempts",
       evaluatorProviderId: "claude",
@@ -493,7 +480,6 @@ describe("SupervisorRepo", () => {
       id: "sup-1",
       sessionId: "sess-1",
       workspaceId: "ws-1",
-      targetId: "target-1",
       state: "idle",
       objective: "Update attempts",
       evaluatorProviderId: "claude",

packages/server/src/storage/repositories/supervisor-repo.ts

@@ -24,7 +24,6 @@ export interface NewSupervisor {
   id: string;
   sessionId: string;
   workspaceId: string;
-  targetId: string;
   state: SupervisorState;
   objective: string;
   evaluatorProviderId: string;
@@ -41,7 +40,6 @@ export interface NewSupervisor {
 }
 
 export interface SupervisorUpdatePatch {
-  targetId?: string;
   state?: SupervisorState;
   objective?: string;
   evaluatorProviderId?: string;

packages/server/src/supervisor/manager.ts

@@ -373,7 +373,6 @@ export class SupervisorManager {
         id: supervisorId,
         sessionId: req.sessionId,
         workspaceId: req.workspaceId,
-        targetId: supervisorId,
         state: "idle",
         objective,
         evaluatorProviderId: req.evaluatorProviderId,