Skip to content

Commit c0c2011

Browse files
committed
fix: prevent desktop build auto publish
1 parent c4df7f6 commit c0c2011

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

scripts/build-desktop.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ describe("build-desktop", () => {
6767
);
6868
});
6969

70-
it("invokes electron-builder using the desktop package publish config", async () => {
70+
it("invokes electron-builder without auto-publishing release artifacts", async () => {
7171
const run = vi.fn(async () => {});
7272

7373
await buildDesktopPackage({
@@ -77,7 +77,7 @@ describe("build-desktop", () => {
7777

7878
expect(run).toHaveBeenCalledWith(
7979
"pnpm",
80-
["exec", "electron-builder", "--projectDir", "/repo/packages/desktop"],
80+
["exec", "electron-builder", "--projectDir", "/repo/packages/desktop", "--publish", "never"],
8181
expect.objectContaining({ cwd: "/repo/packages/desktop" })
8282
);
8383
});
@@ -98,6 +98,8 @@ describe("build-desktop", () => {
9898
"electron-builder",
9999
"--projectDir",
100100
"/repo/packages/desktop",
101+
"--publish",
102+
"never",
101103
"--config.directories.output=/tmp/coder-studio-desktop-release-stage",
102104
],
103105
expect.objectContaining({ cwd: "/repo/packages/desktop" })

scripts/build-desktop.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ export async function buildDesktopPackage(
6565
): Promise<void> {
6666
const exec = input.exec ?? run;
6767
const desktopDir = input.desktopDir ?? DESKTOP_DIR;
68-
const args = ["exec", "electron-builder", "--projectDir", desktopDir];
68+
const args = ["exec", "electron-builder", "--projectDir", desktopDir, "--publish", "never"];
6969

7070
if (input.outputDir) {
7171
args.push(`--config.directories.output=${input.outputDir}`);

0 commit comments

Comments
 (0)