fix: keep empty workbench overlay hidden

Author: pallyoung

apps/web/src/shared/utils/workspace.ts

@@ -394,7 +394,7 @@ export const buildWorkbenchStateFromBootstrap = (
     layout: workbenchLayoutFromBackend(bootstrap.ui_state.layout),
     overlay: {
       ...current.overlay,
-      visible: tabs.length === 0,
+      visible: false,
       input: tabs.length === 0 ? current.overlay.input : "",
     },
   };
@@ -515,7 +515,7 @@ export const applyWorkbenchUiState = (
     layout: workbenchLayoutFromBackend(uiState.layout),
     overlay: {
       ...current.overlay,
-      visible: tabs.length === 0,
+      visible: false,
     },
   };
 };

apps/web/src/state/workbench-core.ts

@@ -430,11 +430,27 @@ const sanitizeTabSessions = (tab: Tab, locale: Locale): Tab => {
 
 export const normalizeWorkbenchState = (input: Partial<WorkbenchState> | null | undefined): WorkbenchState => {
   const fallback = createDefaultWorkbenchState();
-  if (!input?.tabs?.length) return fallback;
+  if (!input?.tabs?.length) {
+    return {
+      ...fallback,
+      overlay: {
+        ...fallback.overlay,
+        visible: false,
+      },
+    };
+  }
 
   const locale = getPreferredLocale();
   const tabs = input.tabs.filter(Boolean).map((tab) => sanitizeTabSessions(tab, locale));
-  if (!tabs.length) return fallback;
+  if (!tabs.length) {
+    return {
+      ...fallback,
+      overlay: {
+        ...fallback.overlay,
+        visible: false,
+      },
+    };
+  }
 
   const activeTabId = tabs.some((tab) => tab.id === input.activeTabId) ? input.activeTabId ?? tabs[0].id : tabs[0].id;
   const hasHistory = tabs.some((tab) =>

tests/workspace-welcome-screen.test.ts

@@ -0,0 +1,66 @@
+import test from "node:test";
+import assert from "node:assert/strict";
+import {
+  normalizeWorkbenchState,
+} from "../apps/web/src/state/workbench-core.ts";
+import {
+  buildWorkbenchStateFromBootstrap,
+} from "../apps/web/src/shared/utils/workspace.ts";
+import {
+  defaultAppSettings,
+} from "../apps/web/src/shared/app/settings.ts";
+
+test("empty workbench state does not auto-open the launch overlay", () => {
+  const normalized = normalizeWorkbenchState({
+    tabs: [],
+    overlay: {
+      visible: true,
+      mode: "local",
+      input: "",
+      target: { type: "native" },
+    },
+  });
+
+  assert.equal(normalized.overlay.visible, false);
+});
+
+test("bootstrap with zero open workspaces keeps the launch overlay hidden", () => {
+  const next = buildWorkbenchStateFromBootstrap(
+    {
+      tabs: [],
+      activeTabId: "",
+      layout: {
+        leftWidth: 320,
+        rightWidth: 320,
+        rightSplit: 64,
+        showCodePanel: true,
+        showTerminalPanel: true,
+      },
+      overlay: {
+        visible: false,
+        mode: "local",
+        input: "",
+        target: { type: "native" },
+      },
+    },
+    {
+      workspaces: [],
+      ui_state: {
+        open_workspace_ids: [],
+        active_workspace_id: null,
+        layout: {
+          left_width: 320,
+          right_width: 320,
+          right_split: 64,
+          show_code_panel: true,
+          show_terminal_panel: true,
+        },
+      },
+    },
+    "en",
+    defaultAppSettings(),
+  );
+
+  assert.equal(next.tabs.length, 0);
+  assert.equal(next.overlay.visible, false);
+});