fix(web): hide extension status entry

Author: pallyoung

packages/web/src/features/workspace/atoms/layout.test.ts

@@ -0,0 +1,8 @@
+import { describe, expect, it } from "vitest";
+import { sanitizeDesktopSidebarView } from "./layout";
+
+describe("workspace layout atoms", () => {
+  it("normalizes the hidden extensions sidebar view to explorer", () => {
+    expect(sanitizeDesktopSidebarView("extensions")).toBe("explorer");
+  });
+});

packages/web/src/features/workspace/atoms/layout.ts

@@ -6,9 +6,9 @@
  * workspace" while the underlying storage is keyed by workspace id.
  */
 
-import { atom, type Getter } from "jotai";
+import { atom, type Getter, type WritableAtom } from "jotai";
 import { atomWithStorage, createJSONStorage } from "jotai/utils";
-import { atomFamily } from "jotai-family";
+import { type AtomFamily, atomFamily } from "jotai-family";
 import type { SetStateAction } from "react";
 import { resolvedActiveWorkspaceIdAtom } from "../../../atoms/workspaces";
 
@@ -17,8 +17,7 @@ export type DesktopSidebarView =
   | "search"
   | "source-control"
   | "agent-instructions"
-  | "skills"
-  | "extensions";
+  | "skills";
 
 export interface WorkspaceLayoutState {
   focusMode: boolean;
@@ -37,7 +36,6 @@ const DESKTOP_SIDEBAR_VIEW_VALUES = new Set<DesktopSidebarView>([
   "source-control",
   "agent-instructions",
   "skills",
-  "extensions",
 ]);
 const DEFAULT_WORKSPACE_LAYOUT_STATE: WorkspaceLayoutState = {
   focusMode: false,
@@ -144,7 +142,14 @@ function resolveNextValue<T>(current: T, update: SetStateAction<T>): T {
   return typeof update === "function" ? (update as (prevState: T) => T)(current) : update;
 }
 
-function createWorkspaceLayoutFieldAtomFamily<Key extends keyof WorkspaceLayoutState>(field: Key) {
+type WorkspaceLayoutFieldAtomFamily<Key extends keyof WorkspaceLayoutState> = AtomFamily<
+  string,
+  WritableAtom<WorkspaceLayoutState[Key], [update: SetStateAction<WorkspaceLayoutState[Key]>], void>
+>;
+
+function createWorkspaceLayoutFieldAtomFamily<Key extends keyof WorkspaceLayoutState>(
+  field: Key
+): WorkspaceLayoutFieldAtomFamily<Key> {
   return atomFamily((workspaceId: string) =>
     atom(
       (get) => get(workspaceLayoutStateAtomFamily(workspaceId))[field],
@@ -165,8 +170,12 @@ function createWorkspaceLayoutFieldAtomFamily<Key extends keyof WorkspaceLayoutS
 }
 
 function createActiveWorkspaceLayoutFieldAtom<Key extends keyof WorkspaceLayoutState>(
-  family: ReturnType<typeof createWorkspaceLayoutFieldAtomFamily<Key>>
-) {
+  family: WorkspaceLayoutFieldAtomFamily<Key>
+): WritableAtom<
+  WorkspaceLayoutState[Key],
+  [update: SetStateAction<WorkspaceLayoutState[Key]>],
+  void
+> {
   return atom(
     (get) => get(family(resolveWorkspaceLayoutId(get))),
     (get, set, update: SetStateAction<WorkspaceLayoutState[Key]>) => {
@@ -196,17 +205,17 @@ export const desktopSidebarViewAtomFamily =
 export const terminalPanelVisibleAtomFamily =
   createWorkspaceLayoutFieldAtomFamily("terminalPanelVisible");
 
-export const focusModeAtom = createActiveWorkspaceLayoutFieldAtom(focusModeAtomFamily);
-export const leftPanelWidthAtom = createActiveWorkspaceLayoutFieldAtom(leftPanelWidthAtomFamily);
-export const bottomPanelHeightAtom = createActiveWorkspaceLayoutFieldAtom(
+export const focusModeAtom = createActiveWorkspaceLayoutFieldAtom<"focusMode">(focusModeAtomFamily);
+export const leftPanelWidthAtom =
+  createActiveWorkspaceLayoutFieldAtom<"leftPanelWidth">(leftPanelWidthAtomFamily);
+export const bottomPanelHeightAtom = createActiveWorkspaceLayoutFieldAtom<"bottomPanelHeight">(
   bottomPanelHeightAtomFamily
 );
-export const sidebarCollapsedAtom = createActiveWorkspaceLayoutFieldAtom(
+export const sidebarCollapsedAtom = createActiveWorkspaceLayoutFieldAtom<"sidebarCollapsed">(
   sidebarCollapsedAtomFamily
 );
-export const desktopSidebarViewAtom = createActiveWorkspaceLayoutFieldAtom(
+export const desktopSidebarViewAtom = createActiveWorkspaceLayoutFieldAtom<"desktopSidebarView">(
   desktopSidebarViewAtomFamily
 );
-export const terminalPanelVisibleAtom = createActiveWorkspaceLayoutFieldAtom(
-  terminalPanelVisibleAtomFamily
-);
+export const terminalPanelVisibleAtom =
+  createActiveWorkspaceLayoutFieldAtom<"terminalPanelVisible">(terminalPanelVisibleAtomFamily);

packages/web/src/features/workspace/index.test.tsx

@@ -362,7 +362,7 @@ describe("WorkspacePage", () => {
     expect(document.querySelector('[data-icon-semantic="nav.sourceControl"]')).toBeTruthy();
     expect(document.querySelector('[data-icon-semantic="nav.agent"]')).toBeTruthy();
     expect(document.querySelector('[data-icon-semantic="nav.skills"]')).toBeTruthy();
-    expect(document.querySelector('[data-icon-semantic="nav.extensions"]')).toBeTruthy();
+    expect(document.querySelector('[data-icon-semantic="nav.extensions"]')).toBeNull();
     expect(
       screen.getByRole("button", { name: /agent\.md|Agent Instructions|Agent 指令/i })
     ).toBeInTheDocument();

packages/web/src/features/workspace/views/desktop/workspace-desktop-view.test.tsx

@@ -7,7 +7,7 @@ import { afterEach, describe, expect, it, vi } from "vitest";
 import { connectionStatusAtom, wsClientAtom } from "../../../../atoms/connection";
 import { activeWorkspaceIdAtom } from "../../../../atoms/workspaces";
 import { seedReadyWorkspaceState } from "../../../../test-utils/workspace-state";
-import { desktopSidebarViewAtomFamily } from "../../atoms/layout";
+import { type DesktopSidebarView, desktopSidebarViewAtomFamily } from "../../atoms/layout";
 import { WorkspaceDesktopView } from "./workspace-desktop-view";
 
 vi.mock("../../../../lib/i18n", () => ({
@@ -123,9 +123,7 @@ vi.mock("../shared/workspace-extension-state-panel", () => ({
   ),
 }));
 
-function renderDesktopView(
-  activeView: "explorer" | "search" | "source-control" | "agent-instructions" | "extensions"
-) {
+function renderDesktopView(activeView: DesktopSidebarView) {
   const store = createStore();
   store.set(connectionStatusAtom, "connected");
   store.set(wsClientAtom, {
@@ -226,12 +224,20 @@ describe("WorkspaceDesktopView", () => {
     expect(screen.getByTestId("workspace-bottom-panel")).toHaveTextContent("Terminal Tasks");
   });
 
-  it("opens the extension-state sidebar panel from the activity bar", () => {
+  it("hides the extension-state activity bar entry", () => {
     renderDesktopView("explorer");
 
-    fireEvent.click(screen.getByRole("button", { name: "Extensions" }));
+    expect(screen.queryByRole("button", { name: "Extensions" })).toBeNull();
+    expect(screen.queryByRole("heading", { level: 2, name: "Extensions" })).toBeNull();
+    expect(screen.queryByText("No extension state")).toBeNull();
+  });
+
+  it("does not open the extension-state panel from the desktop numeric shortcuts", () => {
+    renderDesktopView("explorer");
+
+    fireEvent.keyDown(window, { key: "6", ctrlKey: true });
 
-    expect(screen.getByRole("heading", { level: 2, name: "Extensions" })).toBeInTheDocument();
-    expect(screen.getByText("No extension state")).toBeInTheDocument();
+    expect(screen.queryByRole("heading", { level: 2, name: "Extensions" })).toBeNull();
+    expect(screen.queryByText("No extension state")).toBeNull();
   });
 });

packages/web/src/features/workspace/views/desktop/workspace-desktop-view.tsx

@@ -19,7 +19,6 @@ import { SearchPanel } from "../shared/search-panel";
 import { SkillsPanel } from "../shared/skills-panel";
 import { WorkspaceActivityBar } from "../shared/workspace-activity-bar";
 import { WorkspaceBottomPanel } from "../shared/workspace-bottom-panel";
-import { WorkspaceExtensionStatePanel } from "../shared/workspace-extension-state-panel";
 import { WorkspaceStatusBar } from "../shared/workspace-status-bar";
 
 function isEditableTarget(target: EventTarget | null): boolean {
@@ -111,11 +110,6 @@ const WorkspaceDesktopScene: FC = () => {
         setDesktopSidebarView("skills");
         return;
       }
-
-      if (event.key === "6") {
-        event.preventDefault();
-        setDesktopSidebarView("extensions");
-      }
     };
 
     window.addEventListener("keydown", handleKeyDown);
@@ -184,10 +178,6 @@ const WorkspaceDesktopScene: FC = () => {
                   {activeSidebarView === "skills" ? (
                     <SkillsPanel workspaceId={workspace.id} refreshToken={panelRefreshToken} />
                   ) : null}
-
-                  {activeSidebarView === "extensions" ? (
-                    <WorkspaceExtensionStatePanel workspaceId={workspace.id} />
-                  ) : null}
                 </div>
               </div>
             </aside>
@@ -204,10 +194,7 @@ const WorkspaceDesktopScene: FC = () => {
 
         <div className="workspace-main-area">
           <div className="workspace-main-stage">
-            <div
-              className="agent-panes"
-              aria-hidden={mainAreaMode === "editor" ? true : undefined}
-            >
+            <div className="agent-panes" aria-hidden={mainAreaMode === "editor" ? true : undefined}>
               <AgentPanes hydrateSessions={false} />
             </div>
             {mainAreaMode === "editor" ? (

packages/web/src/features/workspace/views/shared/workspace-activity-bar.tsx

@@ -32,11 +32,6 @@ export const WorkspaceActivityBar: FC<WorkspaceActivityBarProps> = ({
       icon: "nav.agent",
     },
     { view: "skills", label: t("workspace.sidebar.skills"), icon: "nav.skills" },
-    {
-      view: "extensions",
-      label: t("workspace.sidebar.extensions"),
-      icon: "nav.extensions",
-    },
   ];
 
   return (