Skip to content

Commit e336342

Browse files
committed
fix(web): restore full active session pane border
1 parent caccd34 commit e336342

2 files changed

Lines changed: 29 additions & 3 deletions

File tree

packages/web/src/styles/components.css

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14613,6 +14613,17 @@ body.is-dragging-pane .session-action-btn-drag {
1461314613
.session-card.session-card--active {
1461414614
background: var(--workspace-session-active-surface);
1461514615
box-shadow: none;
14616+
position: relative;
14617+
isolation: isolate;
14618+
}
14619+
14620+
.workspace-main-stage .session-card.session-card--active::after {
14621+
content: "";
14622+
position: absolute;
14623+
inset: 0;
14624+
z-index: 1;
14625+
border: 1px solid var(--component-mix-border-focus-84pct-transparent);
14626+
pointer-events: none;
1461614627
}
1461714628

1461814629
.session-header,
@@ -14626,7 +14637,6 @@ body.is-dragging-pane .session-action-btn-drag {
1462614637

1462714638
.session-card.session-card--active > .panel-header,
1462814639
.session-card.session-card--active .session-header {
14629-
border-top: 1px solid var(--component-mix-border-focus-76pct-transparent);
1463014640
border-bottom-color: var(--component-mix-border-focus-76pct-transparent);
1463114641
}
1463214642

packages/web/src/styles/components.theme.test.ts

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1028,6 +1028,9 @@ describe("components.css theme-sensitive surfaces", () => {
10281028
const sessionTerminal = getLastRuleBlock(".session-terminal");
10291029
const sessionCard = getLastRuleBlock(".session-card");
10301030
const activeSessionCard = getLastRuleBlock(".session-card.session-card--active");
1031+
const activeSessionCardOverlay = getLastRuleBlock(
1032+
".workspace-main-stage .session-card.session-card--active::after"
1033+
);
10311034
const activeSessionHeader = getRuleBlocksFrom(
10321035
stylesheet,
10331036
".session-card.session-card--active > .panel-header"
@@ -1148,8 +1151,15 @@ describe("components.css theme-sensitive surfaces", () => {
11481151
expect(activeSessionCard).toContain("background: var(--workspace-session-active-surface)");
11491152
expect(activeSessionCard).not.toContain("background: var(--bg-active)");
11501153
expect(activeSessionCard).toContain("box-shadow: none");
1154+
expect(activeSessionCardOverlay).toContain('content: ""');
1155+
expect(activeSessionCardOverlay).toContain("position: absolute");
1156+
expect(activeSessionCardOverlay).toContain("inset: 0");
1157+
expect(activeSessionCardOverlay).toContain(
1158+
"border: 1px solid var(--component-mix-border-focus-84pct-transparent)"
1159+
);
1160+
expect(activeSessionCardOverlay).toContain("pointer-events: none");
11511161
expect(activeSessionHeader).toContain("background: var(--workspace-session-header-surface)");
1152-
expect(activeSessionHeader).toContain("border-top:");
1162+
expect(activeSessionHeader).not.toContain("border-top:");
11531163
expect(activeSessionHeader).toContain("backdrop-filter: var(--material-backdrop-filter)");
11541164
expect(activeSessionHeader).not.toContain("var(--bg-active) 88%");
11551165
expect(activeSessionTitle).toContain("color: var(--text-primary)");
@@ -1539,6 +1549,9 @@ describe("components.css theme-sensitive surfaces", () => {
15391549
const sessionProgress = getLastRuleBlock(".session-progress");
15401550
const sessionHeader = getLastRuleBlock(".session-header");
15411551
const activeSessionCard = getLastRuleBlock(".session-card.session-card--active");
1552+
const activeSessionCardOverlay = getLastRuleBlock(
1553+
".workspace-main-stage .session-card.session-card--active::after"
1554+
);
15421555
const activeSessionHeader = getLastRuleBlock(
15431556
".session-card.session-card--active > .panel-header"
15441557
);
@@ -1568,7 +1581,10 @@ describe("components.css theme-sensitive surfaces", () => {
15681581
expect(sessionProgress).toContain("background: var(--state-info-bg)");
15691582
expect(sessionHeader).toContain("padding: var(--gap-tight) var(--inset-control-inline)");
15701583
expect(activeSessionCard).toContain("box-shadow: none");
1571-
expect(activeSessionHeader).toContain("border-top:");
1584+
expect(activeSessionCardOverlay).toContain(
1585+
"border: 1px solid var(--component-mix-border-focus-84pct-transparent)"
1586+
);
1587+
expect(activeSessionHeader).not.toContain("border-top:");
15721588
expect(supervisorCard).toContain("background: var(--workspace-session-header-surface)");
15731589
expect(supervisorCard).toContain("backdrop-filter: var(--material-backdrop-filter)");
15741590
expect(sessionHeaderLeft).toContain("gap: var(--gap-default)");

0 commit comments

Comments
 (0)