feat: hydrate terminal preferences at app startup

Author: pallyoung

packages/web/src/app/providers.lifecycle.test.tsx

@@ -10,6 +10,7 @@ import {
   workspacesAtom,
   workspacesLoadStateAtom,
 } from "../atoms/workspaces";
+import { terminalPreferencesAtom } from "../features/terminal-panel/preferences";
 import {
   fileTreeStaleAtomFamily,
   gitBranchListAtomFamily,
@@ -374,6 +375,38 @@ describe("AppProviders lifecycle recovery", () => {
     });
   });
 
+  it("hydrates terminal copy-on-select preferences from settings.get once connected", async () => {
+    const store = createStore();
+    setVisibilityState("visible");
+
+    const sendCommand = vi.fn().mockImplementation(async (op: string) => {
+      if (op === "settings.get") {
+        return {
+          "appearance.terminalCopyOnSelect": true,
+        };
+      }
+
+      return undefined;
+    });
+    wsState.client!.sendCommand = sendCommand;
+
+    renderProviders(store);
+
+    await vi.waitFor(() => {
+      expect(wsState.client?.connect).toHaveBeenCalled();
+    });
+
+    act(() => {
+      wsState.client?.statusHandler?.("connected");
+    });
+
+    await vi.waitFor(() => {
+      expect(store.get(terminalPreferencesAtom)).toEqual({ copyOnSelect: true });
+    });
+
+    expect(sendCommand).toHaveBeenCalledWith("settings.get", {}, undefined);
+  });
+
   it("marks the session authenticated when /auth/status confirms an existing server session", async () => {
     globalThis.fetch = vi.fn().mockResolvedValue({
       json: async () => ({ authEnabled: true, authenticated: true }),

packages/web/src/app/providers.tsx

@@ -39,6 +39,10 @@ import { activeWorkspaceIdAtom } from "../atoms/workspaces";
 import { useSessionNotifications } from "../features/notifications";
 import { supervisorCyclesAtom, supervisorsAtom } from "../features/supervisor/atoms";
 import { terminalMetaAtomFamily } from "../features/terminal-panel/atoms";
+import {
+  resolveTerminalCopyOnSelectSetting,
+  terminalPreferencesAtom,
+} from "../features/terminal-panel/preferences";
 import {
   editorRefreshTokenAtomFamily,
   fileTreeStaleAtomFamily,
@@ -173,6 +177,7 @@ export function AppProviders({ children }: AppProvidersProps) {
   // Supervisor state atoms
   const setSupervisors = useSetAtom(supervisorsAtom);
   const setSupervisorCycles = useSetAtom(supervisorCyclesAtom);
+  const setTerminalPreferences = useSetAtom(terminalPreferencesAtom);
 
   // Get Jotai store for writing to atomFamily atoms
   const store = useStore();
@@ -197,6 +202,31 @@ export function AppProviders({ children }: AppProvidersProps) {
     dispatchRef.current = dispatch;
   }, [dispatch]);
 
+  useEffect(() => {
+    if (connectionStatus !== "connected") {
+      return;
+    }
+
+    let cancelled = false;
+
+    const hydrateTerminalPreferences = async () => {
+      const result = await dispatch<Record<string, unknown>>("settings.get", {});
+      if (cancelled || !result.ok || !result.data) {
+        return;
+      }
+
+      setTerminalPreferences({
+        copyOnSelect: resolveTerminalCopyOnSelectSetting(result.data),
+      });
+    };
+
+    void hydrateTerminalPreferences();
+
+    return () => {
+      cancelled = true;
+    };
+  }, [connectionStatus, dispatch, setTerminalPreferences]);
+
   useEffect(() => {
     activeWorkspaceIdRef.current = activeWorkspaceId;
   }, [activeWorkspaceId]);

packages/web/src/features/terminal-panel/preferences.ts

@@ -0,0 +1,19 @@
+import { atomWithStorage } from "jotai/utils";
+
+export interface TerminalPreferences {
+  copyOnSelect: boolean;
+}
+
+export const DEFAULT_TERMINAL_PREFERENCES: TerminalPreferences = {
+  copyOnSelect: false,
+};
+
+export function resolveTerminalCopyOnSelectSetting(settings: Record<string, unknown>): boolean {
+  const value = settings["appearance.terminalCopyOnSelect"];
+  return typeof value === "boolean" ? value : DEFAULT_TERMINAL_PREFERENCES.copyOnSelect;
+}
+
+export const terminalPreferencesAtom = atomWithStorage<TerminalPreferences>(
+  "ui.terminalPreferences",
+  DEFAULT_TERMINAL_PREFERENCES
+);