fix: ignore stale copy-on-select defaults

Author: pallyoung

packages/web/src/features/settings/components/settings-page.test.tsx

@@ -1108,9 +1108,7 @@ describe("SettingsPage", () => {
     });
 
     await act(async () => {
-      resolveSettingsGet?.({
-        "appearance.terminalCopyOnSelect": false,
-      });
+      resolveSettingsGet?.({});
       await settingsGetPromise;
     });
 

packages/web/src/features/settings/components/settings-page.tsx

@@ -240,18 +240,12 @@ export function SettingsPage() {
           setTerminalRendererState(settings["appearance.terminalRenderer"]);
         }
       }
-      const resolvedTerminalCopyOnSelect = resolveTerminalCopyOnSelectSetting(settings);
-      if (typeof settings["appearance.terminalCopyOnSelect"] === "boolean") {
-        if (
-          appearanceSelectionVersionRef.current.terminalCopyOnSelect ===
-          appearanceSelectionVersionAtRequestStart.terminalCopyOnSelect
-        ) {
-          setTerminalCopyOnSelectState(settings["appearance.terminalCopyOnSelect"]);
-          setTerminalPreferences({
-            copyOnSelect: resolvedTerminalCopyOnSelect,
-          });
-        }
-      } else {
+      if (
+        appearanceSelectionVersionRef.current.terminalCopyOnSelect ===
+        appearanceSelectionVersionAtRequestStart.terminalCopyOnSelect
+      ) {
+        const resolvedTerminalCopyOnSelect = resolveTerminalCopyOnSelectSetting(settings);
+        setTerminalCopyOnSelectState(resolvedTerminalCopyOnSelect);
         setTerminalPreferences({
           copyOnSelect: resolvedTerminalCopyOnSelect,
         });