Skip to content

afiore's android build fixes#10486

Merged
SomberNight merged 5 commits intospesmilo:masterfrom
SomberNight:202602_afiore_android_build
May 6, 2026
Merged

afiore's android build fixes#10486
SomberNight merged 5 commits intospesmilo:masterfrom
SomberNight:202602_afiore_android_build

Conversation

@SomberNight
Copy link
Copy Markdown
Member

Aaron Fiore added 2 commits February 11, 2026 11:24
The previous layers were somewhat senseless; as the buildozer user's
UID and environment must remain static across the entire build.

Resolves: "Usage of undefined variable '$HOME_DIR'"

Refactoring command args also keeps things sane.
Resolves:

    ERROR: Could not open requirements file: [Errno 13] Permission
    denied: '/opt/deterministic-build/requirements-build-base.txt'
Comment thread contrib/android/Dockerfile
SomberNight pushed a commit to SomberNight/electrum that referenced this pull request May 6, 2026
@SomberNight SomberNight marked this pull request as ready for review May 6, 2026 08:18
@SomberNight SomberNight marked this pull request as draft May 6, 2026 08:34
SomberNight pushed a commit to SomberNight/electrum that referenced this pull request May 6, 2026
Comment thread contrib/android/build.sh Outdated
-v "$PROJECT_ROOT_OR_FRESHCLONE_ROOT":/home/user/wspace/electrum \
-v "$PROJECT_ROOT_OR_FRESHCLONE_ROOT"/.buildozer/.gradle:/home/user/.gradle \
$DOCKER_RUN_FLAGS \
--user user \
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Dockerfile already has a USER user directive.
What effect would this docker run --user user have then? Shouldn't it be a NO-OP?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have dropped that commit (3d7d7ac) for now.

Aaron Fiore and others added 3 commits May 6, 2026 10:19
- both "ELECBUILD_COMMIT fresh_clone builds" and "local dev builds"
  should work even when the unix user has a different UID than 1000
  on the host machine
  - though I guess running as root does not work but that's prob ok

issue was:
```
$ echo $UID
1111
$ ./contrib/build-linux/appimage/build.sh
🗯 ERROR: Building outside a git clone is not supported.
```
@SomberNight SomberNight force-pushed the 202602_afiore_android_build branch from d9db1f3 to b3be2a0 Compare May 6, 2026 10:22
@SomberNight SomberNight marked this pull request as ready for review May 6, 2026 10:26
@SomberNight SomberNight merged commit 66f53f5 into spesmilo:master May 6, 2026
0 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant