Skip to content

qml: ElTextArea default topPadding, hide placeholderText on input #10585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SomberNight merged 2 commits into from
Apr 27, 2026
+3 −2
Merged

qml: ElTextArea default topPadding, hide placeholderText on input #10585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9079bad
qml: add default topPadding to ElTextArea
f321x Apr 17, 2026
6872637
qml: ElTextArea: hide placeholder text on user input
f321x Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion electrum/gui/qml/components/NostrConfigDialog.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ ElDialog {
Layout.fillWidth: true
Layout.fillHeight: true
font.family: FixedFont
topPadding: constants.paddingLarge
wrapMode: TextEdit.WrapAnywhere
onTextChanged: valid = verify(text)
inputMethodHints: Qt.ImhSensitiveData | Qt.ImhNoPredictiveText | Qt.ImhNoAutoUppercase
Expand Down
4 changes: 3 additions & 1 deletion electrum/gui/qml/components/controls/ElTextArea.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Flickable {
property alias background: rootpane.background
property alias font: edit.font
property alias inputMethodHints: edit.inputMethodHints
property alias placeholderText: edit.placeholderText
property string placeholderText
property alias color: edit.color
property alias topPadding: rootpane.topPadding
readonly property bool anyActiveFocus: activeFocus || edit.activeFocus
Expand Down Expand Up @@ -49,11 +49,13 @@ Flickable {
width: root.width
height: Math.max(root.height, edit.height + topPadding + bottomPadding)
padding: constants.paddingXSmall
topPadding: constants.paddingLarge
TextArea {
id: edit
width: parent.width
focus: true
wrapMode: TextEdit.Wrap
placeholderText: edit.text.length ? "" : root.placeholderText
onCursorRectangleChanged: root.ensureVisible(cursorRectangle)
onTextChanged: root.textChanged()
background: Rectangle {
Expand Down