Skip to content

tests: lnpeer: fix flaky test "hold_invoice_set_doesnt_get_expired" #10590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecdsa merged 1 commit into from
Apr 21, 2026
Merged

tests: lnpeer: fix flaky test "hold_invoice_set_doesnt_get_expired" #10590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions tests/test_lnpeer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1882,25 +1882,15 @@ async def run_test(test_trampoline):
del bob_w._preimages[pay_req.rhash] # del preimage so bob doesn't settle
payment_key = bob_w._get_payment_key(lnaddr.paymenthash).hex()

cb_got_called = False
cb_got_called = asyncio.Event()
async def cb(_payment_hash):
self.logger.debug(f"hold invoice callback called. {bob_w.network.get_local_height()=}")
nonlocal cb_got_called
cb_got_called = True
cb_got_called.set()

bob_w.register_hold_invoice(lnaddr.paymenthash, cb)

async def check_mpp_state():
async def wait_for_resolution():
while True:
await asyncio.sleep(0.1)
if payment_key not in bob_w.received_mpp_htlcs:
continue
if not bob_w.received_mpp_htlcs[payment_key].resolution == RecvMPPResolution.SETTLING:
continue
return
await util.wait_for2(wait_for_resolution(), timeout=2)
assert cb_got_called
await util.wait_for2(cb_got_called.wait(), timeout=2)
mpp_set = bob_w.received_mpp_htlcs[payment_key]
self.assertEqual(mpp_set.resolution, RecvMPPResolution.SETTLING, msg=mpp_set.resolution)
self.assertEqual(len(mpp_set.htlcs), 1, f"should get only one htlc: {mpp_set.htlcs=}")
Expand Down