fix(qml): add per-word validation feedback in SeedTextArea#10759
Draft
c03rad0r wants to merge 2 commits into
Draft
fix(qml): add per-word validation feedback in SeedTextArea#10759c03rad0r wants to merge 2 commits into
c03rad0r wants to merge 2 commits into
Conversation
Flag individual words not in the BIP39/Electrum wordlist during seed entry on mobile (QML). Shows a red warning label indicating which word(s) are invalid, without blocking input. Changes: - Add isWordInWordlist() slot to QEBitcoin for word validation - Add validateWords property and per-word check to SeedTextArea.qml - Enable validateWords in WCConfirmSeed (retype seed) and WCHaveSeed (restore from seed) wizard pages Closes spesmilo#10758
ban_unicode.py CI check bans non-whitelisted unicode characters.
c03rad0r
force-pushed
the
seed-per-word-validation-qml
branch
from
July 17, 2026 09:43
2123f6d to
d3ab085
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #10758.
On the mobile (QML/Android) GUI, seed confirmation previously only suggested completions for the current word fragment but provided no feedback when a completed word was not in the BIP39 word list.
This PR adds lightweight per-word validation:
isWordValid()method onQEBitcoinchecks a word against the BIP39 + old-mnemonic wordlistSeedTextArea.qmlvalidates all completed words (all but the last) on every text changeFiles changed
electrum/gui/qml/qebitcoin.py— addedisWordValid()slotelectrum/gui/qml/components/controls/SeedTextArea.qml— added_invalidWordIndicesproperty, validation inonTextChanged, and a warningLabelTesting
The change is UI-only and requires the QML GUI to test visually. The logic is straightforward: split text by spaces, check all but the last word against the wordlist.