Skip to content

Commit 32b1c5c

Browse files
committed
session: 'server.version' must tolerate and ignore extra unknown args
to leave room for future extensions
1 parent e819516 commit 32b1c5c

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

src/electrumx/server/session.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1528,11 +1528,14 @@ async def ping(self):
15281528
self.bump_cost(0.1)
15291529
return None
15301530

1531-
async def server_version(self, client_name='', protocol_version=None):
1531+
async def server_version(self, client_name='', protocol_version=None, *extra_args, **extra_kwargs):
15321532
'''Returns the server version as a string.
15331533
15341534
client_name: a string identifying the client
15351535
protocol_version: the protocol version spoken by the client
1536+
1537+
note: extraneous unknown args for 'server.version' MUST be tolerated and ignored by the server,
1538+
to allow for future extensions.
15361539
'''
15371540
self.bump_cost(0.5)
15381541
if self.sv_seen:

0 commit comments

Comments
 (0)