Skip to content

MemFs: Return os.PathError from Remove if directory not empty#233

Closed
knappjf wants to merge 5 commits into
spf13:masterfrom
knappjf:master
Closed

MemFs: Return os.PathError from Remove if directory not empty#233
knappjf wants to merge 5 commits into
spf13:masterfrom
knappjf:master

Conversation

@knappjf

@knappjf knappjf commented Feb 6, 2020

Copy link
Copy Markdown

Possible fix for #232

@0xmichalis

Copy link
Copy Markdown
Collaborator

@knappjf please sign the CLA if you want to get this merged. Thanks!

@CLAassistant

CLAassistant commented May 19, 2020

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@knappjf

knappjf commented Aug 13, 2020

Copy link
Copy Markdown
Author

Oops, forgot about this...had to amend the commits with a different, verified email. Let me know if there's anything else to be done to get this merged!

@spf13

spf13 commented May 7, 2026

Copy link
Copy Markdown
Owner

Superseded by #587, which implements the same fix with cleaner code and is actively being tracked. We've asked the author of #587 to add a test and sign the CLA, after which we'll merge it. Thanks for the original report — this was the right thing to fix.

@spf13 spf13 closed this May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants