fix: use %d format verb for ShellCompDirective in test error message#2432
Closed
amitmishra11 wants to merge 1 commit into
Closed
fix: use %d format verb for ShellCompDirective in test error message#2432amitmishra11 wants to merge 1 commit into
amitmishra11 wants to merge 1 commit into
Conversation
ShellCompDirective is defined as type int. Using the %q format verb with an integer type was flagged as a vet error in Go 1.26 due to a stricter check on format/argument type mismatches, causing the test suite to fail to compile on that version. Replace %q with %d, which is the correct verb for an integer value. Fixes spf13#2422
|
Amit Mishra seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
|
Duplicates of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Go 1.26 tightened
go vetto flag%qused with non-string/rune arguments as an error.ShellCompDirectiveis defined astype ShellCompDirective int, so the format call on line 3730 ofcompletions_test.gonow fails the vet check and prevents the test suite from compiling on Go 1.26.Changes
completions_test.goline 3730: replace%qwith%din thet.Errorfcall that formats aShellCompDirectivevalueTesting
Fixes #2422