fix: handle String() round-trip in Set() for stringToString#489
Closed
happysnaker wants to merge 1 commit into
Closed
fix: handle String() round-trip in Set() for stringToString#489happysnaker wants to merge 1 commit into
happysnaker wants to merge 1 commit into
Conversation
String() wraps the output in [...], but Set() was not stripping those brackets before parsing. This caused round-trip failures when the output of String() (e.g. [x=[]]) was passed back to Set(), resulting in keys like '[x' instead of 'x'. Fixes spf13#413
Author
|
Superseded by existing #414 which addresses the same issue. Closing in favor of the earlier PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #413
String()wraps the output in[...], butSet()was not stripping those brackets before parsing. This caused round-trip failures when the output ofString()(e.g.,[x=[]]) was passed back toSet(), resulting in keys like'[x'instead of'x'.Reproduction
Changes
[...]bracket stripping inSet()at the start of parsing, so the method can handle its ownString()output