Skip to content

remote sprintf not needed #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fmo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remote sprintf not needed #2137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions viper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,14 +285,14 @@ func (v *Viper) WatchConfig() {
go func() {
watcher, err := fsnotify.NewWatcher()
if err != nil {
v.logger.Error(fmt.Sprintf("failed to create watcher: %s", err))
v.logger.Error("failed to create watcher", "err", err)
os.Exit(1)
}
defer watcher.Close()
// we have to watch the entire directory to pick up renames/atomic saves in a cross-platform way
filename, err := v.getConfigFile()
if err != nil {
v.logger.Error(fmt.Sprintf("get config file: %s", err))
v.logger.Error("get config file", "err", err)
initWG.Done()
return
}
Expand Down Expand Up @@ -321,7 +321,7 @@ func (v *Viper) WatchConfig() {
realConfigFile = currentConfigFile
err := v.ReadInConfig()
if err != nil {
v.logger.Error(fmt.Sprintf("read config file: %s", err))
v.logger.Error("read config file", "err", err)
}
if v.onConfigChange != nil {
v.onConfigChange(event)
Expand All @@ -333,7 +333,7 @@ func (v *Viper) WatchConfig() {

case err, ok := <-watcher.Errors:
if ok { // 'Errors' channel is not closed
v.logger.Error(fmt.Sprintf("watcher error: %s", err))
v.logger.Error("watcher error", "err", err)
}
eventsWG.Done()
return
Expand All @@ -342,7 +342,7 @@ func (v *Viper) WatchConfig() {
}()
err = watcher.Add(configDir)
if err != nil {
v.logger.Error(fmt.Sprintf("failed to add watcher: %s", err))
v.logger.Error("failed to add watcher", "err", err)
initWG.Done()
return
}
Expand Down