publish: split post form data and files#1186
Merged
Merged
Conversation
When posting file attachments, this extension historically (since v1.0) published both form and file data through Requests `files` option. This may not have been proper, but has functioned for some time when interacting with stock Confluence Cloud and Confluence Data Center editions. However, recent reports from users have hinted in server processing errors where a Java Spring Framework's `CommonsMultipartFile` usage complains. Unknown if a result of newer framework versions or its use with specific Marketplace addons. No matter the case, this commit aims to correct the post requests when uploading attachment data. This commit ensures any form data is published using Requests `data` argument, and files using `files` argument. Initial testing with Confluence Cloud and Confluence Data Center v10.2.11 show success in publication. Signed-off-by: James Knight <git@jdknight.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When posting file attachments, this extension historically (since v1.0) published both form and file data through Requests
filesoption. This may not have been proper, but has functioned for some time when interacting with stock Confluence Cloud and Confluence Data Center editions.However, recent reports from users have hinted in server processing errors where a Java Spring Framework's
CommonsMultipartFileusage complains. Unknown if a result of newer framework versions or its use with specific Marketplace addons.No matter the case, this commit aims to correct the post requests when uploading attachment data. This commit ensures any form data is published using Requests
dataargument, and files usingfilesargument. Initial testing with Confluence Cloud and Confluence Data Center v10.2.11 show success in publication.