Skip to content

filter .jj directory by default#211

Open
funnes wants to merge 1 commit intosphinx-doc:mainfrom
funnes:qlowutuuvnxt
Open

filter .jj directory by default#211
funnes wants to merge 1 commit intosphinx-doc:mainfrom
funnes:qlowutuuvnxt

Conversation

@funnes
Copy link
Copy Markdown

@funnes funnes commented Mar 18, 2026

This directory is used by jujutsu

@funnes
Copy link
Copy Markdown
Author

funnes commented Apr 22, 2026

I am not sure if the ignore_dirs list works as intended. If I read

def __call__(self, filename: str, /):
correctly, dirs are only ignored when they start with one of the strings in ignore_dirs or if the entry in ignore_dirs is a pattern that matches the dir. so the .git entry, for example, only causes directories that start with .git to be ignored which means the dir /path/to/repo/.git would not be ignored.

@funnes
Copy link
Copy Markdown
Author

funnes commented Apr 22, 2026

the --help output mentions that --ignore takes glob patterns which is not true. the patterns are matched with fnmatch.fnmatch(). the patterns are also interpreted as paths with Path(pattern).resolve().as_posix() which surprised me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant