Fix issue with string args in GenericRelation.#44
Open
ntouran wants to merge 1 commit intosphinx-doc:mainfrom
Open
Fix issue with string args in GenericRelation.#44ntouran wants to merge 1 commit intosphinx-doc:mainfrom
ntouran wants to merge 1 commit intosphinx-doc:mainfrom
Conversation
Fixes sphinx-doc#42. The tests intended to capture the issue but actually don't trigger the real issue in the test scenario, so they may not be appropriate. I tried making a 2nd app to see if the deferred issue would show up but it does not.
Author
|
Looks like I had this linked to wrong issue. Just updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43
The tests intended to capture the issue but actually don't trigger the real issue in the test scenario, so they may not be appropriate. I tried making a 2nd app to see if the deferred issue would show up but it does not.