Namespace packages v2#74
Open
zeehio wants to merge 3 commits into
Open
Conversation
Otherwise I get File "<frozen genericpath>", line 152, in _check_arg_types TypeError: join() argument must be str, bytes, or os.PathLike object, not 'tuple' When I rerun sphinx-build
|
Any chance to have this merged? |
Author
|
Hi, I stoped using this package because I felt it lacked maintenance. I understand we all have too many things to work on and not enough time. In case anyone is interested in pursuing the review and merge of this PR, feel free to continue without me. Best! |
|
Yeah, last commit a year ago was some formatting and comments, and before that was late 2023. Any viable alternatives? |
|
Just wanted to report for posterity that this patch doesn't handle namespace packages coming from multiple source directories. Otherwise works great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a couple of issues with PR #69, so I decided to rebase on the latest master and fix both issues.
I would love to see this merged. Is there anything else I can do to help?
Thanks