Skip to content

Commit 31ab84c

Browse files
SilverRainZDeepSeek
andcommitted
refactor: Remove queue_context helper method
Co-authored-by: DeepSeek <service@deepseek.com>
1 parent 111fcbf commit 31ab84c

2 files changed

Lines changed: 15 additions & 21 deletions

File tree

docs/api.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,22 +18,22 @@ Base Role Classes
1818

1919
.. autoclass:: sphinxnotes.render.BaseContextRole
2020
:show-inheritance:
21-
:members: process_pending_node, queue_pending_node, queue_context, current_context, current_template
21+
:members: process_pending_node, queue_pending_node, current_context, current_template
2222

2323
.. autoclass:: sphinxnotes.render.BaseDataDefineRole
2424
:show-inheritance:
25-
:members: process_pending_node, queue_pending_node, queue_context, current_schema, current_template
25+
:members: process_pending_node, queue_pending_node, current_schema, current_template
2626

2727
Base Directive Classes
2828
----------------------
2929

3030
.. autoclass:: sphinxnotes.render.BaseContextDirective
3131
:show-inheritance:
32-
:members: process_pending_node, queue_pending_node, queue_context, current_raw_data, current_context, current_template
32+
:members: process_pending_node, queue_pending_node, current_raw_data, current_context, current_template
3333

3434
.. autoclass:: sphinxnotes.render.BaseDataDefineDirective
3535
:show-inheritance:
36-
:members: process_pending_node, queue_pending_node, queue_context, current_raw_data, current_schema, current_template
36+
:members: process_pending_node, queue_pending_node, current_raw_data, current_schema, current_template
3737

3838
.. autoclass:: sphinxnotes.render.StrictDataDefineDirective
3939
:show-inheritance:

src/sphinxnotes/render/pipeline.py

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -79,15 +79,6 @@ def queue_pending_node(self, n: pending_node) -> None:
7979
self._q = []
8080
self._q.append(n)
8181

82-
@final
83-
def queue_context(
84-
self, ctx: UnresolvedContext | ResolvedContext, tmpl: Template
85-
) -> pending_node:
86-
"""A helper method for ``queue_pending_node``."""
87-
pending = pending_node(ctx, tmpl)
88-
self.queue_pending_node(pending)
89-
return pending
90-
9182
@final
9283
def render_queue(self) -> list[pending_node]:
9384
"""
@@ -196,7 +187,10 @@ class BaseContextDirective(BaseContextSource, SphinxDirective):
196187
@final
197188
@override
198189
def run(self) -> list[nodes.Node]:
199-
self.queue_context(self.current_context(), self.current_template())
190+
pending = pending_node(
191+
self.current_context(), self.current_template(), rawsource=self.block_text
192+
)
193+
self.queue_pending_node(pending)
200194

201195
ns = []
202196
for x in self.render_queue():
@@ -216,16 +210,16 @@ class BaseContextRole(BaseContextSource, SphinxRole):
216210
to provide the constructor parameters of ``pending_node``.
217211
"""
218212

219-
@override
220-
def process_pending_node(self, n: pending_node) -> bool:
221-
n.inline = True
222-
return super().process_pending_node(n)
223-
224213
@final
225214
@override
226215
def run(self) -> tuple[list[nodes.Node], list[nodes.system_message]]:
227-
pending = self.queue_context(self.current_context(), self.current_template())
228-
pending.inline = True
216+
pending = pending_node(
217+
self.current_context(),
218+
self.current_template(),
219+
rawsource=self.rawtext,
220+
inline=True,
221+
)
222+
self.queue_pending_node(pending)
229223

230224
ns, msgs = [], []
231225
for n in self.render_queue():

0 commit comments

Comments
 (0)