Skip to content

Commit bb5c345

Browse files
committed
refactor: pending_data -> pending_node, rendered_data -> rendered_node
1 parent 00c4094 commit bb5c345

5 files changed

Lines changed: 46 additions & 46 deletions

File tree

src/sphinxnotes/data/__init__.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@
2727
Phase,
2828
Template,
2929
Host,
30-
pending_data,
31-
rendered_data,
30+
pending_node,
31+
rendered_node,
3232
BaseDataDefineRole,
3333
BaseDataDefineDirective,
3434
ExtraContextRegistry,
@@ -55,9 +55,9 @@
5555
'Phase',
5656
'Template',
5757
'Host',
58-
'pending_data',
59-
'rendered_data',
60-
'rendered_data',
58+
'pending_node',
59+
'rendered_node',
60+
'rendered_node',
6161
'BaseDataDefineRole',
6262
'BaseDataDefineDirective',
6363
'StrictDataDefineDirective',

src/sphinxnotes/data/render/__init__.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from typing import TYPE_CHECKING
33

44
from .render import Phase, Template, Host
5-
from .datanodes import pending_data, rendered_data
5+
from .datanodes import pending_node, rendered_node
66
from .pipeline import (
77
BaseDataDefineRole,
88
BaseDataDefineDirective,
@@ -17,9 +17,9 @@
1717
'Phase',
1818
'Template',
1919
'Host',
20-
'pending_data',
21-
'rendered_data',
22-
'rendered_data',
20+
'pending_node',
21+
'rendered_node',
22+
'rendered_node',
2323
'BaseDataDefineRole',
2424
'BaseDataDefineDirective',
2525
'ExtraContextRegistry',

src/sphinxnotes/data/render/datanodes.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
class Base(nodes.Element): ...
2626

2727

28-
class pending_data(Base, Unpicklable):
28+
class pending_node(Base, Unpicklable):
2929
# The data to be rendered by Jinja template.
3030
data: PendingData | ParsedData | dict[str, Any]
3131
# The extra context for Jina template.
@@ -56,7 +56,7 @@ def __init__(
5656
self._markup_text_hooks = []
5757
self._rendered_nodes_hooks = []
5858

59-
def render(self, host: Host) -> rendered_data:
59+
def render(self, host: Host) -> rendered_node:
6060
"""
6161
The core function for rendering data to docutils nodes.
6262
@@ -65,7 +65,7 @@ def render(self, host: Host) -> rendered_data:
6565
3. MarkupRenderer.render(Markup Text) -> doctree Nodes (list[nodes.Node])
6666
"""
6767
# 0. Create container for rendered nodes.
68-
rendered = rendered_data()
68+
rendered = rendered_node()
6969
# Copy attributes from pending_node.
7070
rendered.update_all_atts(self)
7171
# Copy source and line (which are not included in update_all_atts).
@@ -145,8 +145,8 @@ def render(self, host: Host) -> rendered_data:
145145

146146
return rendered
147147

148-
def replace_self_inline(self, rendered: rendered_data) -> None:
149-
# Split inline nodes and system_message noeds from rendered_data node.
148+
def replace_self_inline(self, rendered: rendered_node) -> None:
149+
# Split inline nodes and system_message noeds from rendered_node node.
150150
ns, msgs = rendered.inline(parent=self.parent)
151151

152152
# Insert reports to nearst block elements (usually nodes.paragraph).
@@ -161,11 +161,11 @@ def replace_self_inline(self, rendered: rendered_data) -> None:
161161

162162
"""Hooks for procssing render intermediate products. """
163163

164-
type RawDataHook = Callable[[pending_data, RawData], None]
165-
type ParsedDataHook = Callable[[pending_data, RawData], None]
166-
type MarkupTextHook = Callable[[pending_data, str], None]
164+
type RawDataHook = Callable[[pending_node, RawData], None]
165+
type ParsedDataHook = Callable[[pending_node, RawData], None]
166+
type MarkupTextHook = Callable[[pending_node, str], None]
167167
type RenderedNodesHook = Callable[
168-
[pending_data, list[nodes.Node], list[nodes.system_message]], None
168+
[pending_node, list[nodes.Node], list[nodes.system_message]], None
169169
]
170170

171171
_raw_data_hooks: list[RawDataHook]
@@ -186,7 +186,7 @@ def process_rendered_nodes(self, hook: RenderedNodesHook) -> None:
186186
self._rendered_nodes_hooks.append(hook)
187187

188188

189-
class rendered_data(Base, nodes.container):
189+
class rendered_node(Base, nodes.container):
190190
# The data used when rendering this node.
191191
data: ParsedData | dict[str, Any] | None
192192

src/sphinxnotes/data/render/extractx.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
from sphinx.util.docutils import SphinxDirective
66

77
from .render import HostWrapper
8-
from .datanodes import pending_data
8+
from .datanodes import pending_node
99
from ..utils import find_current_section, Report, Reporter
1010
from ..utils.ctxproxy import proxy
1111

@@ -127,12 +127,12 @@ def generate(self) -> Any:
127127

128128

129129
class ExtraContextGenerator:
130-
node: pending_data
130+
node: pending_node
131131
report: Report
132132

133133
registry: ClassVar[ExtraContextRegistry] = ExtraContextRegistry()
134134

135-
def __init__(self, node: pending_data) -> None:
135+
def __init__(self, node: pending_node) -> None:
136136
self.node = node
137137
self.report = Report(
138138
'Extra Context Generation Report',

src/sphinxnotes/data/render/pipeline.py

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@
1010
The Pipline
1111
===========
1212
13-
1. Define data: BaseDataDefiner generates a :cls:`pending_data`, which contains:
13+
1. Define data: BaseDataDefiner generates a :cls:`pending_node`, which contains:
1414
1515
- Data and possible extra contexts
1616
- Schema for validating Data
1717
- Template for rendering data to markup text
1818
19-
2. Render data: the ``pending_data`` nodes will be rendered
19+
2. Render data: the ``pending_node`` nodes will be rendered
2020
(by calling :meth:`pending_node.render`) at some point, depending on :cls:`Phase`.
2121
2222
The one who calls ``pending_node.render`` is called ``Host``.
@@ -37,7 +37,7 @@
3737
How :cls:`RawData` be rendered ``list[nodes.Node]``
3838
===================================================
3939
40-
.. seealso:: :meth:`.datanodes.pending_data.render`.
40+
.. seealso:: :meth:`.datanodes.pending_node.render`.
4141
4242
"""
4343

@@ -51,7 +51,7 @@
5151
from sphinx.transforms.post_transforms import SphinxPostTransform, ReferencesResolver
5252

5353
from .render import Phase, Template, Host, ParseHost, TransformHost
54-
from .datanodes import pending_data, rendered_data
54+
from .datanodes import pending_node, rendered_node
5555
from .extractx import ExtraContextGenerator
5656
from ..data import RawData, PendingData, ParsedData, Schema
5757

@@ -64,11 +64,11 @@
6464

6565
class Pipeline(ABC):
6666
#: Queue of pending node to be rendered.
67-
_q: list[pending_data] | None = None
67+
_q: list[pending_node] | None = None
6868

6969
"""Methods to be overrided."""
7070

71-
def process_pending_node(self, n: pending_data) -> bool:
71+
def process_pending_node(self, n: pending_node) -> bool:
7272
"""
7373
You can add hooks to pending node here.
7474
@@ -78,43 +78,43 @@ def process_pending_node(self, n: pending_data) -> bool:
7878
"""
7979
...
8080

81-
def process_rendered_node(self, n: rendered_data) -> None: ...
81+
def process_rendered_node(self, n: rendered_node) -> None: ...
8282

8383
"""Helper method for subclasses."""
8484

8585
@final
86-
def queue(self, n: pending_data) -> None:
86+
def queue(self, n: pending_node) -> None:
8787
if not self._q:
8888
self._q = []
8989
self._q.append(n)
9090

9191
@final
9292
def queue_raw_data(
9393
self, data: RawData, schema: Schema, tmpl: Template
94-
) -> pending_data:
95-
pending = pending_data(PendingData(data, schema), tmpl)
94+
) -> pending_node:
95+
pending = pending_node(PendingData(data, schema), tmpl)
9696
self.queue(pending)
9797
return pending
9898

9999
@final
100-
def queue_parsed_data(self, data: ParsedData, tmpl: Template) -> pending_data:
101-
pending = pending_data(data, tmpl)
100+
def queue_parsed_data(self, data: ParsedData, tmpl: Template) -> pending_node:
101+
pending = pending_node(data, tmpl)
102102
self.queue(pending)
103103
return pending
104104

105105
@final
106-
def queue_any_data(self, data: Any, tmpl: Template) -> pending_data:
107-
pending = pending_data(data, tmpl)
106+
def queue_any_data(self, data: Any, tmpl: Template) -> pending_node:
107+
pending = pending_node(data, tmpl)
108108
self.queue(pending)
109109
return pending
110110

111111
@final
112-
def render_queue(self) -> list[pending_data | rendered_data]:
112+
def render_queue(self) -> list[pending_node | rendered_node]:
113113
"""
114114
Try rendering all pending nodes in queue.
115115
116-
If the timing(Phase) is ok, :cls:`pending_data` will be rendered to a
117-
:cls:`rendered_data`; otherwise, the pending node is unchanged.
116+
If the timing(Phase) is ok, :cls:`pending_node` will be rendered to a
117+
:cls:`rendered_node`; otherwise, the pending node is unchanged.
118118
119119
If the pending node is already inserted to document, it will not be return.
120120
And the corrsponding rendered node will replace it too.
@@ -169,7 +169,7 @@ def current_template(self) -> Template: ...
169169
"""Methods override from parent."""
170170

171171
@override
172-
def process_pending_node(self, n: pending_data) -> bool:
172+
def process_pending_node(self, n: pending_node) -> bool:
173173
host = cast(ParseHost, self)
174174

175175
# Set source and line.
@@ -204,7 +204,7 @@ def current_data(self) -> RawData:
204204
return RawData(None, {}, self.text)
205205

206206
@override
207-
def process_pending_node(self, n: pending_data) -> bool:
207+
def process_pending_node(self, n: pending_node) -> bool:
208208
n.inline = True
209209
return super().process_pending_node(n)
210210

@@ -216,7 +216,7 @@ def run(self) -> tuple[list[nodes.Node], list[nodes.system_message]]:
216216

217217
ns, msgs = [], []
218218
for n in self.render_queue():
219-
if not isinstance(n, rendered_data):
219+
if not isinstance(n, rendered_node):
220220
ns.append(n)
221221
continue
222222
n, msg = n.inline(parent=self.inliner.parent)
@@ -228,7 +228,7 @@ def run(self) -> tuple[list[nodes.Node], list[nodes.system_message]]:
228228

229229
class _ParsedHook(SphinxDirective, Pipeline):
230230
@override
231-
def process_pending_node(self, n: pending_data) -> bool:
231+
def process_pending_node(self, n: pending_node) -> bool:
232232
self.state.document.note_source(n.source, n.line) # type: ignore[arg-type]
233233

234234
# Generate and save parsed extra context for later use.
@@ -240,7 +240,7 @@ def process_pending_node(self, n: pending_data) -> bool:
240240
def run(self) -> list[nodes.Node]:
241241
logger.warning(f'running parsed hook for doc {self.env.docname}...')
242242

243-
for pending in self.state.document.findall(pending_data):
243+
for pending in self.state.document.findall(pending_node):
244244
self.queue(pending)
245245
# Hook system_message method to let it report the
246246
# correct line number.
@@ -273,7 +273,7 @@ class _ResolvingHook(SphinxPostTransform, Pipeline):
273273
default_priority = (ReferencesResolver.default_priority or 10) + 5
274274

275275
@override
276-
def process_pending_node(self, n: pending_data) -> bool:
276+
def process_pending_node(self, n: pending_node) -> bool:
277277
# Generate and save post transform extra context for later use.
278278
ExtraContextGenerator(n).on_post_transform(cast(TransformHost, self))
279279

@@ -283,7 +283,7 @@ def process_pending_node(self, n: pending_data) -> bool:
283283
def apply(self, **kwargs):
284284
logger.warning(f'running resolving hook for doc {self.env.docname}...')
285285

286-
for pending in self.document.findall(pending_data):
286+
for pending in self.document.findall(pending_node):
287287
self.queue(pending)
288288

289289
ns = self.render_queue()

0 commit comments

Comments
 (0)