Skip to content

Commit 61c920c

Browse files
claudespiceClaude
andauthored
fix: Correct PostgreSQL accelerator connection pool parameter name and defaults (#1528)
* fix: Add nanosecond timestamp range limitation to MSSQL and Oracle versioned docs Commit d5341c4 documented the Arrow nanosecond timestamp range limitation (~1677–2262) for MSSQL and Oracle connectors, but only in website/docs/ (vNext). The limitation existed in all prior versions too — in versions 1.5.x–1.11.x, out-of-range timestamps silently returned 1970-01-01 UTC instead of erroring. Propagate the limitation note to all 7 versioned doc directories (14 files total) with version-appropriate wording. * fix: Correct PostgreSQL accelerator connection pool parameter name and defaults The docs listed pg_connection_pool_min_idle (default 1) and connection_pool_size (default 5), but the code uses pg_connection_pool_min (default 5) and connection_pool_size (default 10). --------- Co-authored-by: Claude <claude@Claudes-Mini.localdomain>
1 parent 673da3b commit 61c920c

5 files changed

Lines changed: 10 additions & 10 deletions

File tree

  • website
    • docs/components/data-accelerators/postgres
    • versioned_docs
      • version-1.10.x/components/data-accelerators/postgres
      • version-1.11.x/components/data-accelerators/postgres
      • version-1.8.x/components/data-accelerators/postgres
      • version-1.9.x/components/data-accelerators/postgres

website/docs/components/data-accelerators/postgres/index.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ The connection to PostgreSQL can be configured by providing the following `param
3838
- `prefer`: This mode will try to establish a secure TLS connection if possible, but will connect insecurely if the server does not support TLS.
3939
- `disable`: This mode will not attempt to use a TLS connection, even if the server supports it.
4040
- `pg_sslrootcert`: Optional parameter specifying the path to a custom PEM certificate that the connector will trust.
41-
- `pg_connection_pool_min_idle`: Optional. The minimum number of idle connections to keep open in the pool. Default is `1`.
42-
- `connection_pool_size`: Optional. The maximum number of connections to keep open in the connection pool. Default is `5`.
41+
- `pg_connection_pool_min`: Optional. The minimum number of connections to keep open in the pool, lazily created when requested. Default is `5`.
42+
- `connection_pool_size`: Optional. The maximum number of connections created in the connection pool. Default is `10`.
4343

4444
Configuration `params` are provided in the `acceleration` section of a dataset.
4545

website/versioned_docs/version-1.10.x/components/data-accelerators/postgres/index.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ The connection to PostgreSQL can be configured by providing the following `param
3434
- `prefer`: This mode will try to establish a secure TLS connection if possible, but will connect insecurely if the server does not support TLS.
3535
- `disable`: This mode will not attempt to use a TLS connection, even if the server supports it.
3636
- `pg_sslrootcert`: Optional parameter specifying the path to a custom PEM certificate that the connector will trust.
37-
- `pg_connection_pool_min_idle`: Optional. The minimum number of idle connections to keep open in the pool. Default is `1`.
38-
- `connection_pool_size`: Optional. The maximum number of connections to keep open in the connection pool. Default is `5`.
37+
- `pg_connection_pool_min`: Optional. The minimum number of connections to keep open in the pool, lazily created when requested. Default is `5`.
38+
- `connection_pool_size`: Optional. The maximum number of connections created in the connection pool. Default is `10`.
3939

4040
Configuration `params` are provided either in the `acceleration` section of a dataset.
4141

website/versioned_docs/version-1.11.x/components/data-accelerators/postgres/index.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ The connection to PostgreSQL can be configured by providing the following `param
3434
- `prefer`: This mode will try to establish a secure TLS connection if possible, but will connect insecurely if the server does not support TLS.
3535
- `disable`: This mode will not attempt to use a TLS connection, even if the server supports it.
3636
- `pg_sslrootcert`: Optional parameter specifying the path to a custom PEM certificate that the connector will trust.
37-
- `pg_connection_pool_min_idle`: Optional. The minimum number of idle connections to keep open in the pool. Default is `1`.
38-
- `connection_pool_size`: Optional. The maximum number of connections to keep open in the connection pool. Default is `5`.
37+
- `pg_connection_pool_min`: Optional. The minimum number of connections to keep open in the pool, lazily created when requested. Default is `5`.
38+
- `connection_pool_size`: Optional. The maximum number of connections created in the connection pool. Default is `10`.
3939

4040
Configuration `params` are provided in the `acceleration` section of a dataset.
4141

website/versioned_docs/version-1.8.x/components/data-accelerators/postgres/index.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ The connection to PostgreSQL can be configured by providing the following `param
3434
- `prefer`: This mode will try to establish a secure TLS connection if possible, but will connect insecurely if the server does not support TLS.
3535
- `disable`: This mode will not attempt to use a TLS connection, even if the server supports it.
3636
- `pg_sslrootcert`: Optional parameter specifying the path to a custom PEM certificate that the connector will trust.
37-
- `pg_connection_pool_min_idle`: Optional. The minimum number of idle connections to keep open in the pool. Default is `1`.
38-
- `connection_pool_size`: Optional. The maximum number of connections to keep open in the connection pool. Default is `5`.
37+
- `pg_connection_pool_min`: Optional. The minimum number of connections to keep open in the pool, lazily created when requested. Default is `5`.
38+
- `connection_pool_size`: Optional. The maximum number of connections created in the connection pool. Default is `10`.
3939

4040
Configuration `params` are provided either in the `acceleration` section of a dataset.
4141

website/versioned_docs/version-1.9.x/components/data-accelerators/postgres/index.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ The connection to PostgreSQL can be configured by providing the following `param
3434
- `prefer`: This mode will try to establish a secure TLS connection if possible, but will connect insecurely if the server does not support TLS.
3535
- `disable`: This mode will not attempt to use a TLS connection, even if the server supports it.
3636
- `pg_sslrootcert`: Optional parameter specifying the path to a custom PEM certificate that the connector will trust.
37-
- `pg_connection_pool_min_idle`: Optional. The minimum number of idle connections to keep open in the pool. Default is `1`.
38-
- `connection_pool_size`: Optional. The maximum number of connections to keep open in the connection pool. Default is `5`.
37+
- `pg_connection_pool_min`: Optional. The minimum number of connections to keep open in the pool, lazily created when requested. Default is `5`.
38+
- `connection_pool_size`: Optional. The maximum number of connections created in the connection pool. Default is `10`.
3939

4040
Configuration `params` are provided either in the `acceleration` section of a dataset.
4141

0 commit comments

Comments
 (0)