fix: Correct PostgreSQL accelerator connection pool parameter name and defaults#1528
Merged
fix: Correct PostgreSQL accelerator connection pool parameter name and defaults#1528
Conversation
added 2 commits
April 18, 2026 03:11
…rsioned docs Commit d5341c4 documented the Arrow nanosecond timestamp range limitation (~1677–2262) for MSSQL and Oracle connectors, but only in website/docs/ (vNext). The limitation existed in all prior versions too — in versions 1.5.x–1.11.x, out-of-range timestamps silently returned 1970-01-01 UTC instead of erroring. Propagate the limitation note to all 7 versioned doc directories (14 files total) with version-appropriate wording.
…d defaults The docs listed pg_connection_pool_min_idle (default 1) and connection_pool_size (default 5), but the code uses pg_connection_pool_min (default 5) and connection_pool_size (default 10).
✅ Pull with Spice PassedPassing checks:
|
|
🚀 deployed to https://19b7d14e.spiceai-org-website.pages.dev |
sgrebnov
approved these changes
Apr 20, 2026
Copilot AI
pushed a commit
that referenced
this pull request
Apr 21, 2026
…d defaults (#1528) * fix: Add nanosecond timestamp range limitation to MSSQL and Oracle versioned docs Commit d5341c4 documented the Arrow nanosecond timestamp range limitation (~1677–2262) for MSSQL and Oracle connectors, but only in website/docs/ (vNext). The limitation existed in all prior versions too — in versions 1.5.x–1.11.x, out-of-range timestamps silently returned 1970-01-01 UTC instead of erroring. Propagate the limitation note to all 7 versioned doc directories (14 files total) with version-appropriate wording. * fix: Correct PostgreSQL accelerator connection pool parameter name and defaults The docs listed pg_connection_pool_min_idle (default 1) and connection_pool_size (default 5), but the code uses pg_connection_pool_min (default 5) and connection_pool_size (default 10). --------- Co-authored-by: Claude <claude@Claudes-Mini.localdomain> Co-authored-by: lukekim <80174+lukekim@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pg_connection_pool_min_idlewith a default of1, but the code defines the parameter aspg_connection_pool_minwith a default of5connection_pool_sizedefault was documented as5, but the code uses10Changes
pg_connection_pool_min_idle→pg_connection_pool_minacross all versioned docs (1.8.x–1.11.x) and vNextpg_connection_pool_mindefault from1→5connection_pool_sizedefault from5→10Reference
Verified against
spiceai/spiceaiattrunk—crates/runtime/src/dataaccelerator/postgres.rs(lines 61–62, 92–99)Also verified at tags
v1.8.0,v1.9.2,v1.10.4,v1.11.5— same parameter name and defaults across all versions.