fix: Document missing file_format parameter for SharePoint connector#1532
Closed
claudespice wants to merge 9 commits intotrunkfrom
Closed
fix: Document missing file_format parameter for SharePoint connector#1532claudespice wants to merge 9 commits intotrunkfrom
claudespice wants to merge 9 commits intotrunkfrom
Conversation
added 6 commits
April 18, 2026 03:11
…rsioned docs Commit d5341c4 documented the Arrow nanosecond timestamp range limitation (~1677–2262) for MSSQL and Oracle connectors, but only in website/docs/ (vNext). The limitation existed in all prior versions too — in versions 1.5.x–1.11.x, out-of-range timestamps silently returned 1970-01-01 UTC instead of erroring. Propagate the limitation note to all 7 versioned doc directories (14 files total) with version-appropriate wording.
…d defaults The docs listed pg_connection_pool_min_idle (default 1) and connection_pool_size (default 5), but the code uses pg_connection_pool_min (default 5) and connection_pool_size (default 10).
The docs stated the default ssl_mode is tls, but the code has always used auto as the default since at least v1.5.0.
The docs showed the default time format as 2006-01-02T15:04:05Z07:00 but the code uses 2006-01-02T15:04:05.000Z07:00 (with .000 milliseconds). This matters because Go format strings are exact patterns — without .000, timestamps with millisecond precision would not parse correctly.
The PostgreSQL connector added logical replication (WAL streaming) support in PR #10364 with 5 new parameters (pg_replication_slot, pg_publication, pg_replication_initial_snapshot, pg_replication_temporary_slot, pg_replication_status_interval) that were not yet documented.
The SharePoint connector defines a file_format runtime parameter in its ParameterSpec that was not documented. Other file-based connectors (S3, ABFS, NFS, SMB, FTP) already document this parameter.
✅ Pull with Spice PassedPassing checks:
|
lukekim
approved these changes
Apr 20, 2026
lukekim
approved these changes
Apr 20, 2026
auto-merge was automatically disabled
April 27, 2026 00:44
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file_formatruntime parameter in its ParameterSpec but the parameter was not documentedChanges
file_formatto the SharePoint connector parameter table across all 8 doc versions (vNext + 1.5.x through 1.11.x)Reference
Verified against
spiceai/spiceaiattrunk—crates/data-connectors/connector-sharepoint/src/lib.rs(line 134:ParameterSpec::runtime("file_format"))Also verified present at tags
v1.5.0throughv1.11.5.