Correcting color to match rosepine moon + sidebar text actually white#1263
Correcting color to match rosepine moon + sidebar text actually white#1263yoy333 wants to merge 3 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 WalkthroughThe rose-pine-moon palette in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Ziro/color.ini`:
- Around line 239-240: The color values for the keys selected-row and button
include trailing spaces ("e0def4 " and "ea9a97 "); remove the trailing
whitespace so the values are exactly the 6-character hex strings (e.g., "e0def4"
and "ea9a97") in the Ziro/color.ini file to avoid producing 7-character invalid
hex values—update the entries for selected-row and button accordingly and ensure
consistency with the other color lines.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
https://rosepinetheme.com/palette/ingredients/
As you can see here, the moon variant was incorrect. Also the sidebar text was rose, which imo is not good looking.
Summary by CodeRabbit