Conversation
suvayu
commented
Feb 26, 2026
Contributor
Author
suvayu
left a comment
suvayu
left a comment
There was a problem hiding this comment.
Is it possible to factor out the tool changes (both for the plot & data download, they may live together) into a function that can be called on the figure object?
I'm asking because this needs to be replicated for plot_barchart. The functionality is identical.
Comment on lines
+421
to
+423
| } else { | ||
| console.error("QWebChannel bridge not available"); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Is it possible to also show an error to the user in a popup? I'm guessing if webchannel is not available, maybe it should be something using JS?
- crashes on parameter_value editor view (double-click) - replaced mpl canvas with webview, so that don't have to deal with window/widget related assumptions made by spine - only plot the first parameter_value - hack around titles and labels - adhoc figure size, maybe infer from data?
FIXME: cleanup, switch to dataframe API
Unfortunately the bridge is needed. Registering the whole PlotWidget with QWebChannel causes errors since its built-in properties like `modal`, `geometry`, `enabled`, etc. lack "notify" signals that are otherwise required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QWebEngineView) based plotting widget usingbokehspinedb_apifor testingFeature list
parameter_valueeditorChecklist before merging