Spin 4.0#183
Conversation
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
…ne too Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
force-pushed
the
spin-4.0
branch
2 times, most recently
from
5ffd849 to
c0532c7
Compare
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
…sorry Signed-off-by: itowlson <ivan.towlson@fermyon.com>
|
@fibonacci1729 I think this is about as ready as I can get it for now - still have Go/JS/Python changes to make once those are ready, and a few possible changes to the Rust SDK as we discussed. Let me know if you see / can think of anything else that needs to change! |
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
| <select class="version-dropdown" | ||
| onchange="this.options[this.selectedIndex].value && (window.location = this.options[this.selectedIndex].value);"> | ||
| <option value="/v3/index">Spin v3.x</option> | ||
| <option value="/v4/index">Spin v4.x</option> |
There was a problem hiding this comment.
Should this be <option value="/v4/index" {{#if (active_project request.spin-full-url "/v4/" )}} selected {{/if}}>Spin v4.x</option>?
There was a problem hiding this comment.
Hmm, I am not sure. I believe I followed the v3 pattern here because I assumed this was how we did "default selection". @karthik2804 do you know what this should look like?
(Thinking about it... if we left v3 as default and marked this as "v4.x (preview)" then we could potentially land this in main already and just rev it to default once v4 is out.)
There was a problem hiding this comment.
I have to remind myself of how this works. I will take a look tomorrow morning.
| <a {{#if (active_project request.spin-full-url "/v4/triggers" )}} class="active" {{/if}} href="{{site.info.base_url}}/v4/triggers">Overview</a> | ||
| <a {{#if (active_project request.spin-full-url "/v4/http-trigger" )}} class="active" {{/if}} href="{{site.info.base_url}}/v4/http-trigger"> HTTP Trigger</a> | ||
| <a {{#if (active_project request.spin-full-url "/v4/redis-trigger" )}} class="active" {{/if}} href="{{site.info.base_url}}/v4/redis-trigger"> Redis Trigger</a> | ||
| <a {{#if (active_project request.spin-full-url "/v4/redis-trigger" )}} class="active" {{/if}} href="{{site.info.base_url}}/v4/triggers#cron-trigger">Cron Trigger</a> |
There was a problem hiding this comment.
| <a {{#if (active_project request.spin-full-url "/v4/redis-trigger" )}} class="active" {{/if}} href="{{site.info.base_url}}/v4/triggers#cron-trigger">Cron Trigger</a> | |
| <a {{#if (active_project request.spin-full-url "/v4/cron-trigger" )}} class="active" {{/if}} href="{{site.info.base_url}}/v4/triggers#cron-trigger">Cron Trigger</a> |
There was a problem hiding this comment.
Ugh, this (copied from v3) is clearly wrong, but there isn't a cron-trigger page, only a triggers page, and that is associated with the Overview TOC item. I guess I will have two checks for the triggers page rather than two checks for the redis-trigger page because that is at least less wrong. Something to reassess after v4.
|
|
||
| ### Configuration-Based Permissions | ||
|
|
||
| You can use [application variables](./variables.md#adding-variables-to-your-applications) in the `allowed_outbound_hosts` field. However, this feature is not yet available on Fermyon Cloud. |
There was a problem hiding this comment.
Another question about mentioning fermyon cloud.
|
|
||
| * `--max-instance-reuse-count` sets the maximum number of times a single instance can be reused | ||
| * `--max-instance-concurrent-reuse-count` sets the maximum number of requests that can be running in a single instance at the same time | ||
| * `--idle-instance-timeout` controls how long Spin will allow a reusable instance to be sit idle before evicting it |
There was a problem hiding this comment.
| * `--idle-instance-timeout` controls how long Spin will allow a reusable instance to be sit idle before evicting it | |
| * `--idle-instance-timeout` controls how long Spin will allow a reusable instance to sit idle before evicting it |
|
Overall looking great! Instead of commenting individually: Several v4 pages still mention "Fermyon Cloud" or "not yet available on Fermyon Cloud." Since
|
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: Vaughn Dice <vdice@akamai.com>
|
@itowlson I created a PR on your fork with this branch as its base adding updates to the Py code snippets/links/etc: itowlson#1 |
Co-authored-by: itowlson <github@hestia.cc> Signed-off-by: Vaughn Dice <vdice@akamai.com>
Signed-off-by: Vaughn Dice <vdice@akamai.com>
Signed-off-by: Vaughn Dice <vdice@akamai.com>
docs(v4): update Python code snippets/links/details
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
|
@fibonacci1729 @vdice I have set this so it continues to default to v3, and has v4 Preview as an option. This means that we can, if we want, merge this as is. This would allow me to re-enable some of the link checks and fix the inevitable mistakes, and would mean folks wanting to kick tyres on canary have something to refer to. Then when we want to swap over it will be a 2-line change instead of this beast. |
4 participants
Work in progress! I've put the initial "fork all the things" stuff in the initial commit so in principle you can review the boilerplate for boilerplatey things and the content changes for actual content separately, but I dunno, maybe I should make two separate PRs, anyway, v4, WIP.
need to confirm which APIs we are asyncifyingthis is looking settled, revisit if it changeshttp_service-fied Rust. Streaming outbound reqs/resps in Rust - done (check once SDK lands). TODO: Go, JS, Python.http_service- added.http_componenttohttp_service. Revisited example responses.spin testreference until we can work on thathttp_service, response guff: Rust done. TODO: JS, Go, PythonGeneral things:
wasm32-wasip1towasm32-wasip2