Avoid unneeded schema change for view updates#10
Closed
SergeiPatiakin wants to merge 2 commits intomainfrom
Closed
Avoid unneeded schema change for view updates#10SergeiPatiakin wants to merge 2 commits intomainfrom
SergeiPatiakin wants to merge 2 commits intomainfrom
Conversation
gruuya
approved these changes
Apr 29, 2025
| branch, | ||
| } => { | ||
| let schema_changed = metadata.current_schema(branch.as_deref()) | ||
| .map(|s| schema != *s.fields()) |
Collaborator
There was a problem hiding this comment.
In theory identifier_field_ids can change while the fields remain the same, so we should also test for that when deducing a schema change?
Author
There was a problem hiding this comment.
In theory you're right, but looks like iceberg-rs doesn't support changing identifier_field_ids, so identifier_field_ids are not even represented in variant Operation::UpdateRepresentation
Collaborator
There was a problem hiding this comment.
Oh I see; then no need to test it now.
Author
|
Merged upstream as JanKaul#166 |
Author
|
Closing because merged upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the new schema is the same as the old schema, there is no need to update it