Skip to content

Avoid unneeded schema change for view updates #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SergeiPatiakin wants to merge 2 commits into from
Closed

Avoid unneeded schema change for view updates #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61dbca1
Reorder steps in Operation::execute for Operation::UpdateRepresentation
SergeiPatiakinEdb Apr 28, 2025
75340b9
Conditional AddSchema
SergeiPatiakinEdb Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 34 additions & 19 deletions iceberg-rust/src/view/transaction/operation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,17 @@ impl Operation {
schema,
branch,
} => {
let schema_changed = metadata.current_schema(branch.as_deref())
.map(|s| schema != *s.fields())
Copy link
Copy Markdown
Collaborator

@gruuya gruuya Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory identifier_field_ids can change while the fields remain the same, so we should also test for that when deducing a schema change?

Copy link
Copy Markdown
Author

@SergeiPatiakin SergeiPatiakin Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory you're right, but looks like iceberg-rs doesn't support changing identifier_field_ids, so identifier_field_ids are not even represented in variant Operation::UpdateRepresentation

Copy link
Copy Markdown
Collaborator

@gruuya gruuya Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see; then no need to test it now.

.unwrap_or(true);

let version = metadata.current_version(branch.as_deref())?;
let version_id = metadata.versions.keys().max().unwrap_or(&0) + 1;
let schema_id = metadata.schemas.keys().max().unwrap_or(&0) + 1;
let schema_id = if schema_changed {
metadata.schemas.keys().max().unwrap_or(&0) + 1
} else {
*metadata.current_schema(branch.as_deref()).unwrap().schema_id()
};
let last_column_id = schema.iter().map(|x| x.id).max().unwrap_or(0);

let version = Version {
Expand All @@ -72,28 +80,35 @@ impl Operation {

let branch_name = branch.unwrap_or("main".to_string());

let mut view_updates: Vec<ViewUpdate<T>> = if schema_changed {
vec![ViewUpdate::AddSchema {
schema: Schema::from_struct_type(schema, schema_id, None),
last_column_id: Some(last_column_id),
}]
} else {
vec![]
};

view_updates.append(&mut vec![
ViewUpdate::AddViewVersion {
view_version: version,
},
ViewUpdate::SetCurrentViewVersion {
view_version_id: version_id,
},
ViewUpdate::SetProperties {
updates: HashMap::from_iter(vec![(
REF_PREFIX.to_string() + &branch_name,
version_id.to_string(),
)]),
},
]);

Ok((
Some(ViewRequirement::AssertViewUuid {
uuid: metadata.view_uuid,
}),
vec![
ViewUpdate::AddViewVersion {
view_version: version,
},
ViewUpdate::SetCurrentViewVersion {
view_version_id: version_id,
},
ViewUpdate::AddSchema {
schema: Schema::from_struct_type(schema, schema_id, None),
last_column_id: Some(last_column_id),
},
ViewUpdate::SetProperties {
updates: HashMap::from_iter(vec![(
REF_PREFIX.to_string() + &branch_name,
version_id.to_string(),
)]),
},
],
view_updates,
))
}
Operation::UpdateProperties(entries) => Ok((
Expand Down