Skip to content

Fix the rage click system #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HJewkes wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix the rage click system #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbaaa26
Fix the rage click system
HJewkes Aug 6, 2021
ccd9736
Update click.js
HJewkes Aug 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 25 additions & 14 deletions src/tracking/click.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import {finder} from '@medv/finder'

export default class ClickTracker {
constructor(splitClient, tracked=[]) {
this.splitClient = splitClient;
this.tracked = tracked || [];
this.tracked = tracked;

this.RAGE_MIN_CLICKS = 5; // 5 clicks
this.RAGE_COOLDOWN = 300; // Less than 300 ms apart
Expand All @@ -22,9 +24,9 @@ export default class ClickTracker {
// Trackers

trackClick(clickEvent) {
const target = finder(clickEvent.target);
const rage = this.isRageClick(clickEvent);
if(rage || this.isTrackedElement(clickEvent)) {
const target = clickEvent.target || clickEvent.srcElement;
if(rage || this.isTrackedElement(target)) {
const properties = {
"click.target": target,
"click.rage": rage
Expand All @@ -35,8 +37,7 @@ export default class ClickTracker {

// Internal Methods

isTrackedElement(clickEvent) {
const target = clickEvent.target || clickEvent.srcElement;
isTrackedElement(target) {
if(this.tracked.find((selector) => target.matches(selector))) {
return true;
} else {
Expand All @@ -45,25 +46,35 @@ export default class ClickTracker {
}

isRageClick(clickEvent, currentTime = this.now()) {
const target = clickEvent.target || clickEvent.srcElement;
if(this.lastClick && this.lastClick.target === target && currentTime - this.lastClick.time < this.RAGE_COOLDOWN) {
if(this.lastClick && this.lastClick.target === clickEvent.target && currentTime - this.lastClick.time < this.RAGE_COOLDOWN) {
const delay = currentTime - this.lastClick.time;

var rage = false;
if(!this.lastClick.triggered && this.lastClick.count >= this.RAGE_MIN_CLICKS) {
// Rage confirmed
rage = true;
}
console.log(rage)

// Some rage, update state
this.lastClick = {
target: target,
target: clickEvent.target,
count: this.lastClick.count + 1,
time: currentTime,
triggered: false,
triggered: rage || this.lastClick.triggered,
delay: delay
};

if(!this.lastClick.triggered && this.lastClick.count >= this.RAGE_MIN_CLICKS) {
// Rage confirmed
return true;
if(rage) {
const rage_event = new CustomEvent('split.rage_click', this.lastClick);
document.dispatchEvent(rage_event);
}

return rage;
} else {
// No rage, reset state
this.lastClick = {
target: target,
target: clickEvent.target,
count: 1,
time: currentTime,
triggered: false,
Expand All @@ -77,4 +88,4 @@ export default class ClickTracker {
now() {
return new Date().getTime();
}
}
}