Skip to content

Commit 01c1841

Browse files
committed
FME-15373-impressions: git mv pure-leaf impression files, DTOs, filters, and clean strategy files to impressions module
- Move impression DTOs (KeyImpression, TestImpressions, ImpressionCount, DecoratedImpression, UniqueKeys) - Move core impression files (Impression, ImpressionCounter, ImpressionHasher, ImpressionObserver, ImpressionUtils, ImpressionsResult, ImpressionsSender, ImpressionsStorage*, InMemoryImpressionsStorage, ImpressionsManager, ImpressionListener, UniqueKeysTracker) - Move filters/ package wholesale (BloomFilterImp, Filter, FilterAdapter, FilterAdapterImpl) - Move clean strategy files (ProcessImpressionDebug, ProcessImpressionNone, ProcessImpressionStrategy) - Copy MurmurHash3 into impressions module to avoid targeting-engine dependency - Replace Preconditions.checkNotNull with Objects.requireNonNull in ImpressionCounter - Add hamcrest-all test dep; fix ImpressionObserverTest logger reference - impressions module builds and all moved tests pass standalone AI-Session-Id: 52375eb8-af89-45b8-bbad-1698b6636202 AI-Tool: claude-code AI-Model: unknown
1 parent 3b21371 commit 01c1841

39 files changed

Lines changed: 310 additions & 4 deletions

impressions/pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,12 @@
3737
<artifactId>junit</artifactId>
3838
<scope>test</scope>
3939
</dependency>
40+
<dependency>
41+
<groupId>org.hamcrest</groupId>
42+
<artifactId>hamcrest-all</artifactId>
43+
<version>1.3</version>
44+
<scope>test</scope>
45+
</dependency>
4046
<dependency>
4147
<groupId>org.mockito</groupId>
4248
<artifactId>mockito-core</artifactId>

client/src/main/java/io/split/client/dtos/DecoratedImpression.java renamed to impressions/src/main/java/io/split/client/dtos/DecoratedImpression.java

File renamed without changes.

client/src/main/java/io/split/client/dtos/ImpressionCount.java renamed to impressions/src/main/java/io/split/client/dtos/ImpressionCount.java

File renamed without changes.

client/src/main/java/io/split/client/dtos/KeyImpression.java renamed to impressions/src/main/java/io/split/client/dtos/KeyImpression.java

File renamed without changes.

client/src/main/java/io/split/client/dtos/TestImpressions.java renamed to impressions/src/main/java/io/split/client/dtos/TestImpressions.java

File renamed without changes.

client/src/main/java/io/split/client/dtos/UniqueKeys.java renamed to impressions/src/main/java/io/split/client/dtos/UniqueKeys.java

File renamed without changes.

client/src/main/java/io/split/client/impressions/Impression.java renamed to impressions/src/main/java/io/split/client/impressions/Impression.java

File renamed without changes.

client/src/main/java/io/split/client/impressions/ImpressionCounter.java renamed to impressions/src/main/java/io/split/client/impressions/ImpressionCounter.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,14 @@
55
import java.util.concurrent.ConcurrentHashMap;
66
import java.util.concurrent.atomic.AtomicInteger;
77

8-
import static com.google.common.base.Preconditions.checkNotNull;
9-
108
public class ImpressionCounter {
119

1210
public static class Key {
1311
private final String _featureName;
1412
private final long _timeFrame;
1513

1614
public Key(String featureFlagName, long timeframe) {
17-
_featureName = checkNotNull(featureFlagName);
15+
_featureName = Objects.requireNonNull(featureFlagName);
1816
_timeFrame = timeframe;
1917
}
2018

client/src/main/java/io/split/client/impressions/ImpressionHasher.java renamed to impressions/src/main/java/io/split/client/impressions/ImpressionHasher.java

File renamed without changes.

client/src/main/java/io/split/client/impressions/ImpressionListener.java renamed to impressions/src/main/java/io/split/client/impressions/ImpressionListener.java

File renamed without changes.

0 commit comments

Comments
 (0)