Merge pull request #498 from splitio/development

Release v2.12.1

Author: EmilianoSanchez

.gitignore

@@ -12,3 +12,11 @@
 
 ## coverage info
 /coverage
+
+## worktrees
+/.worktrees
+
+## agents files
+/AGENTS.md
+/CLAUDE.md
+/.claude

CHANGES.txt

@@ -1,5 +1,9 @@
+2.12.1 (June 25, 2026)
+ - Updated internal modules to handle `null` values from `/splitChanges` response.
+ - Updated some dependencies for vulnerability fixes.
+
 2.12.0 (February 24, 2026)
- - Added support for ioredis v5.
+ - Added support for ioredis v5 (Related to issue https://github.com/splitio/javascript-commons/issues/471).
 
 2.11.0 (January 28, 2026)
  - Added functionality to provide metadata alongside SDK update and READY events. Read more in our docs.

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@splitsoftware/splitio-commons",
-  "version": "2.12.0",
+  "version": "2.12.1",
   "description": "Split JavaScript SDK common components",
   "main": "cjs/index.js",
   "module": "esm/index.js",
@@ -60,10 +60,10 @@
     "@types/ioredis": "^4.28.0",
     "@types/jest": "^27.0.0",
     "@types/lodash": "^4.14.162",
-    "@typescript-eslint/eslint-plugin": "^6.6.0",
-    "@typescript-eslint/parser": "^6.6.0",
+    "@typescript-eslint/eslint-plugin": "^7.18.0",
+    "@typescript-eslint/parser": "^7.18.0",
     "cross-env": "^7.0.2",
-    "eslint": "^8.48.0",
+    "eslint": "^8.56.0",
     "eslint-plugin-compat": "^6.0.1",
     "eslint-plugin-import": "^2.25.3",
     "eslint-plugin-tsdoc": "^0.3.0",
@@ -76,7 +76,7 @@
     "redis-server": "1.2.2",
     "rimraf": "^3.0.2",
     "ts-jest": "^27.0.5",
-    "typescript": "4.4.4"
+    "typescript": "4.7.4"
   },
   "sideEffects": false
 }

package.json

@@ -23,7 +23,7 @@ export interface IBetweenStringMatcherData {
 }
 
 export interface IWhitelistMatcherData {
-  whitelist: string[]
+  whitelist?: string[] | null
 }
 
 export interface IInSegmentMatcherData {
@@ -41,10 +41,10 @@ export interface IDependencyMatcherData {
 
 interface ISplitMatcherBase {
   matcherType: string
-  negate: boolean
-  keySelector: null | {
+  negate?: boolean
+  keySelector?: null | {
     trafficType: string,
-    attribute: string | null
+    attribute?: string | null
   }
   userDefinedSegmentMatcherData?: null | IInSegmentMatcherData
   userDefinedLargeSegmentMatcherData?: null | IInLargeSegmentMatcherData
@@ -207,18 +207,18 @@ export interface IExcludedSegment {
 export interface IRBSegment {
   name: string,
   changeNumber: number,
-  status: 'ACTIVE' | 'ARCHIVED',
-  conditions?: ISplitCondition[],
+  status?: 'ACTIVE' | 'ARCHIVED',
+  conditions?: ISplitCondition[] | null,
   excluded?: {
     keys?: string[] | null,
     segments?: IExcludedSegment[] | null
-  }
+  } | null
 }
 
 export interface ISplit {
   name: string,
   changeNumber: number,
-  status: 'ACTIVE' | 'ARCHIVED',
+  status?: 'ACTIVE' | 'ARCHIVED',
   conditions: ISplitCondition[],
   prerequisites?: null | {
     n: string,
@@ -232,9 +232,9 @@ export interface ISplit {
   trafficAllocationSeed?: number
   configurations?: {
     [treatmentName: string]: string
-  },
-  sets?: string[],
-  impressionsDisabled?: boolean
+  } | null,
+  sets?: string[] | null,
+  impressionsDisabled?: boolean | null
 }
 
 // Split definition used in offline mode
@@ -245,13 +245,13 @@ export interface ISplitChangesResponse {
   ff?: {
     t: number,
     s?: number,
-    d: ISplit[]
-  },
+    d?: ISplit[] | null,
+  } | null,
   rbs?: {
     t: number,
     s?: number,
-    d: IRBSegment[]
-  }
+    d?: IRBSegment[] | null,
+  } | null,
 }
 
 /** Interface of the parsed JSON response of `/segmentChanges/{segmentName}` */

src/dtos/types.ts

@@ -18,10 +18,10 @@ export function getTreatment(log: ILogger, key: string, seed: number | undefined
 /**
  * Evaluates the traffic allocation to see if we should apply rollout conditions or not.
  */
-export function shouldApplyRollout(trafficAllocation: number, key: string, trafficAllocationSeed: number) {
+export function shouldApplyRollout(trafficAllocation: number, bucketingKey: string, trafficAllocationSeed: number) {
   // For rollout, if traffic allocation for splits is 100%, we don't need to filter it because everything should evaluate the rollout.
   if (trafficAllocation < 100) {
-    const _bucket = bucket(key, trafficAllocationSeed);
+    const _bucket = bucket(bucketingKey, trafficAllocationSeed);
 
     if (_bucket > trafficAllocation) {
       return false;

src/evaluator/__tests__/evaluate-feature.spec.ts

@@ -9,8 +9,8 @@ describe('FallbackTreatmentsCalculator' , () => {
         'featureA': { treatment: 'TREATMENT_A', config: '{ value: 1 }' },
       },
     };
-    const calculator = new FallbackTreatmentsCalculator(config);
-    const result = calculator.resolve('featureA', 'label by flag');
+    const calculator = FallbackTreatmentsCalculator(config);
+    const result = calculator('featureA', 'label by flag');
 
     expect(result).toEqual({
       treatment: 'TREATMENT_A',
@@ -24,8 +24,8 @@ describe('FallbackTreatmentsCalculator' , () => {
       byFlag: {},
       global: { treatment: 'GLOBAL_TREATMENT', config: '{ global: true }' },
     };
-    const calculator = new FallbackTreatmentsCalculator(config);
-    const result = calculator.resolve('missingFlag', 'label by global');
+    const calculator = FallbackTreatmentsCalculator(config);
+    const result = calculator('missingFlag', 'label by global');
 
     expect(result).toEqual({
       treatment: 'GLOBAL_TREATMENT',
@@ -38,8 +38,8 @@ describe('FallbackTreatmentsCalculator' , () => {
     const config: FallbackTreatmentConfiguration = {
       byFlag: {},
     };
-    const calculator = new FallbackTreatmentsCalculator(config);
-    const result = calculator.resolve('missingFlag', 'label by noFallback');
+    const calculator = FallbackTreatmentsCalculator(config);
+    const result = calculator('missingFlag', 'label by noFallback');
 
     expect(result).toEqual({
       treatment: CONTROL,

src/evaluator/__tests__/evaluate-features.spec.ts

@@ -1,50 +1,32 @@
-import { FallbackTreatmentConfiguration, Treatment, TreatmentWithConfig } from '../../../types/splitio';
+import { FallbackTreatmentConfiguration, TreatmentWithConfig } from '../../../types/splitio';
 import { CONTROL } from '../../utils/constants';
 import { isString } from '../../utils/lang';
 
-export type IFallbackTreatmentsCalculator = {
-  resolve(flagName: string, label: string): TreatmentWithConfig & { label: string };
-}
+export type IFallbackTreatmentsCalculator = (flagName: string, label?: string) => TreatmentWithConfig & { label: string };
 
 export const FALLBACK_PREFIX = 'fallback - ';
 
-export class FallbackTreatmentsCalculator implements IFallbackTreatmentsCalculator {
-  private readonly fallbacks: FallbackTreatmentConfiguration;
-
-  constructor(fallbacks: FallbackTreatmentConfiguration = {}) {
-    this.fallbacks = fallbacks;
-  }
-
-  resolve(flagName: string, label: string): TreatmentWithConfig & { label: string } {
-    const treatment = this.fallbacks.byFlag?.[flagName];
-    if (treatment) {
-      return this.copyWithLabel(treatment, label);
-    }
-
-    if (this.fallbacks.global) {
-      return this.copyWithLabel(this.fallbacks.global, label);
-    }
-
-    return {
-      treatment: CONTROL,
-      config: null,
-      label,
-    };
-  }
-
-  private copyWithLabel(fallback: Treatment | TreatmentWithConfig, label: string): TreatmentWithConfig & { label: string } {
-    if (isString(fallback)) {
-      return {
-        treatment: fallback,
+export function FallbackTreatmentsCalculator(fallbacks: FallbackTreatmentConfiguration = {}): IFallbackTreatmentsCalculator {
+
+  return (flagName: string, label = '') => {
+    const fallback = fallbacks.byFlag?.[flagName] || fallbacks.global;
+
+    return fallback ?
+      isString(fallback) ?
+        {
+          treatment: fallback,
+          config: null,
+          label: `${FALLBACK_PREFIX}${label}`,
+        } :
+        {
+          treatment: fallback.treatment,
+          config: fallback.config,
+          label: `${FALLBACK_PREFIX}${label}`,
+        } :
+      {
+        treatment: CONTROL,
         config: null,
-        label: `${FALLBACK_PREFIX}${label}`,
+        label,
       };
-    }
-
-    return {
-      treatment: fallback.treatment,
-      config: fallback.config,
-      label: `${FALLBACK_PREFIX}${label}`,
-    };
-  }
+  };
 }