Skip to content

Commit 92756e4

Browse files
Update logs
1 parent d448fd8 commit 92756e4

6 files changed

Lines changed: 10 additions & 10 deletions

File tree

src/listeners/node.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,14 +58,14 @@ export class NodeSignalListener implements ISignalListener {
5858
process.kill(process.pid, SIGTERM);
5959
};
6060

61-
this.settings.log.debug(`${LOG_PREFIX_CLEANUP}Split SDK graceful shutdown after SIGTERM.`);
61+
this.settings.log.debug(`${LOG_PREFIX_CLEANUP}SDK graceful shutdown after SIGTERM.`);
6262

6363
let handlerResult = null;
6464

6565
try {
6666
handlerResult = this.handler();
6767
} catch (err) {
68-
this.settings.log.error(`${LOG_PREFIX_CLEANUP}Error with Split SDK graceful shutdown: ${err}`);
68+
this.settings.log.error(`${LOG_PREFIX_CLEANUP}Error with SDK graceful shutdown: ${err}`);
6969
}
7070

7171
if (thenable(handlerResult)) {

src/logger/messages/info.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import * as c from '../constants';
22
import { codesWarn } from './warn';
33

4-
const READY_MSG = 'Split SDK client is ready';
4+
const READY_MSG = 'SDK client is ready';
55

66
export const codesInfo: [number, string][] = codesWarn.concat([
77
// client status
@@ -10,7 +10,7 @@ export const codesInfo: [number, string][] = codesWarn.concat([
1010
// SDK
1111
[c.IMPRESSION_QUEUEING, c.LOG_PREFIX_IMPRESSIONS_TRACKER +'Queueing impression. %s: %s. Key: %s. Evaluation: %s. Label: %s'],
1212
[c.NEW_SHARED_CLIENT, 'New shared client instance created.'],
13-
[c.NEW_FACTORY, 'New Split SDK instance created. %s'],
13+
[c.NEW_FACTORY, 'New SDK instance created. %s'],
1414
[c.EVENTS_TRACKER_SUCCESS, c.LOG_PREFIX_EVENTS_TRACKER + 'Successfully queued %s'],
1515
[c.IMPRESSIONS_TRACKER_SUCCESS, c.LOG_PREFIX_IMPRESSIONS_TRACKER + 'Successfully stored %s impression(s).'],
1616
[c.USER_CONSENT_UPDATED, 'UserConsent: consent status changed from %s to %s.'],

src/readiness/__tests__/sdkReadinessManager.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ function emitReadyEvent(readinessManager: IReadinessManager) {
3434
if (readinessManager.gate.once.mock.calls[3]) readinessManager.gate.once.mock.calls[3][1](); // whenReady promise
3535
}
3636

37-
const timeoutErrorMessage = 'Split SDK emitted SDK_READY_TIMED_OUT event.';
37+
const timeoutErrorMessage = 'SDK client emitted SDK_READY_TIMED_OUT event.';
3838

3939
// Makes readinessManager emit SDK_READY_TIMED_OUT & update hasTimedout flag
4040
function emitTimeoutEvent(readinessManager: IReadinessManager) {
@@ -230,15 +230,15 @@ describe('SDK Readiness Manager - Ready promise', () => {
230230
readyForTimeout = sdkReadinessManager.sdkStatus.ready();
231231

232232
setTimeout(() => {
233-
expect(loggerMock.error).lastCalledWith('Split SDK has emitted SDK_READY_TIMED_OUT event.'); // If we don\'t handle a new .ready() rejected promise, an error is logged.
233+
expect(loggerMock.error).lastCalledWith('SDK client has emitted SDK_READY_TIMED_OUT event.'); // If we don\'t handle a new .ready() rejected promise, an error is logged.
234234
readyForTimeout = sdkReadinessManager.sdkStatus.ready();
235235

236236
readyForTimeout
237237
.then(() => { throw new Error(); })
238238
.then(() => { throw new Error(); })
239239
.catch((error) => {
240240
expect(error instanceof Error).toBe(true);
241-
expect(error.message).toBe('Split SDK has emitted SDK_READY_TIMED_OUT event.');
241+
expect(error.message).toBe('SDK client has emitted SDK_READY_TIMED_OUT event.');
242242
expect(loggerMock.error).toBeCalledTimes(2); // If we provide an onRejected handler, even chaining several onFulfilled handlers, the error is not logged.
243243
done();
244244
});

src/readiness/readinessManager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ export function readinessManagerFactory(
6969
if (hasTimedout || isReady) return;
7070
hasTimedout = true;
7171
syncLastUpdate();
72-
gate.emit(SDK_READY_TIMED_OUT, 'Split SDK emitted SDK_READY_TIMED_OUT event.');
72+
gate.emit(SDK_READY_TIMED_OUT, 'SDK client emitted SDK_READY_TIMED_OUT event.');
7373
}
7474

7575

src/readiness/sdkReadinessManager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ export function sdkReadinessManagerFactory(
9696
ready() {
9797
if (readinessManager.hasTimedout()) {
9898
if (!readinessManager.isReady()) {
99-
return promiseWrapper(Promise.reject(new Error('Split SDK has emitted SDK_READY_TIMED_OUT event.')), defaultOnRejected);
99+
return promiseWrapper(Promise.reject(new Error('SDK client has emitted SDK_READY_TIMED_OUT event.')), defaultOnRejected);
100100
} else {
101101
return Promise.resolve();
102102
}

types/splitio.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2394,7 +2394,7 @@ declare namespace SplitIO {
23942394
* You can use it, for example, for certificate pinning or setting a network proxy:
23952395
*
23962396
* ```
2397-
* const { ConfigsClient } = require('@splitsoftware/splitio-configs');
2397+
* const { ConfigsClient } = require('@splitsoftware/configs');
23982398
* const { HttpsProxyAgent } = require('https-proxy-agent');
23992399
*
24002400
* const proxyAgent = new HttpsProxyAgent(process.env.HTTPS_PROXY || 'http://10.10.1.10:1080');

0 commit comments

Comments
 (0)