Handle null values in /splitChanges response for sets, ff.d, and rbs.d fields

EmilianoSanchez · EmilianoSanchez · commit eb99cbd54ed0 · 2026-04-28T16:26:40.000-03:00
AI-Session-Id: 616e2b0b-7059-4a31-b636-080938576336
AI-Tool: claude-code
AI-Model: unknown
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -1,3 +1,6 @@
+2.12.1 (April 28, 2026)
+ - Updated internal modules to handle `null` values from `/splitChanges` response.
+
 2.12.0 (February 24, 2026)
  - Added support for ioredis v5 (Related to issue https://github.com/splitio/javascript-commons/issues/471).
 
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@splitsoftware/splitio-commons",
-  "version": "2.12.0",
+  "version": "2.12.1",
   "description": "Split JavaScript SDK common components",
   "main": "cjs/index.js",
   "module": "esm/index.js",
diff --git a/src/dtos/types.ts b/src/dtos/types.ts
@@ -232,8 +232,8 @@ export interface ISplit {
   trafficAllocationSeed?: number
   configurations?: {
     [treatmentName: string]: string
-  },
-  sets?: string[],
+  } | null,
+  sets?: string[] | null,
   impressionsDisabled?: boolean
 }
 
@@ -245,12 +245,12 @@ export interface ISplitChangesResponse {
   ff?: {
     t: number,
     s?: number,
-    d: ISplit[]
+    d?: ISplit[] | null,
   },
   rbs?: {
     t: number,
     s?: number,
-    d: IRBSegment[]
+    d?: IRBSegment[] | null,
   }
 }
 
diff --git a/src/storages/inLocalStorage/SplitsCacheInLocal.ts b/src/storages/inLocalStorage/SplitsCacheInLocal.ts
@@ -205,7 +205,7 @@ export class SplitsCacheInLocal extends AbstractSplitsCacheSync {
     });
   }
 
-  private removeFromFlagSets(featureFlagName: string, flagSets?: string[]) {
+  private removeFromFlagSets(featureFlagName: string, flagSets?: string[] | null) {
     if (!flagSets) return;
 
     flagSets.forEach(flagSet => {
diff --git a/src/storages/inMemory/SplitsCacheInMemory.ts b/src/storages/inMemory/SplitsCacheInMemory.ts
@@ -114,7 +114,7 @@ export class SplitsCacheInMemory extends AbstractSplitsCacheSync {
     });
   }
 
-  private removeFromFlagSets(featureFlagName: string, flagSets: string[] | undefined) {
+  private removeFromFlagSets(featureFlagName: string, flagSets?: string[] | null) {
     if (!flagSets) return;
     flagSets.forEach(flagSet => {
       this.removeNames(flagSet, featureFlagName);
diff --git a/src/storages/inRedis/SplitsCacheInRedis.ts b/src/storages/inRedis/SplitsCacheInRedis.ts
@@ -59,7 +59,7 @@ export class SplitsCacheInRedis extends AbstractSplitsCacheAsync {
     return this.redis.incr(ttKey);
   }
 
-  private _updateFlagSets(featureFlagName: string, flagSetsOfRemovedFlag?: string[], flagSetsOfAddedFlag?: string[]) {
+  private _updateFlagSets(featureFlagName: string, flagSetsOfRemovedFlag?: string[] | null, flagSetsOfAddedFlag?: string[] | null) {
     const removeFromFlagSets = returnDifference(flagSetsOfRemovedFlag, flagSetsOfAddedFlag);
 
     let addToFlagSets = returnDifference(flagSetsOfAddedFlag, flagSetsOfRemovedFlag);
diff --git a/src/storages/pluggable/SplitsCachePluggable.ts b/src/storages/pluggable/SplitsCachePluggable.ts
@@ -43,7 +43,7 @@ export class SplitsCachePluggable extends AbstractSplitsCacheAsync {
     return this.wrapper.incr(ttKey);
   }
 
-  private _updateFlagSets(featureFlagName: string, flagSetsOfRemovedFlag?: string[], flagSetsOfAddedFlag?: string[]) {
+  private _updateFlagSets(featureFlagName: string, flagSetsOfRemovedFlag?: string[] | null, flagSetsOfAddedFlag?: string[] | null) {
     const removeFromFlagSets = returnDifference(flagSetsOfRemovedFlag, flagSetsOfAddedFlag);
 
     let addToFlagSets = returnDifference(flagSetsOfAddedFlag, flagSetsOfRemovedFlag);
diff --git a/src/storages/setRolloutPlan.ts b/src/storages/setRolloutPlan.ts
@@ -35,12 +35,12 @@ export function setRolloutPlan(log: ILogger, rolloutPlan: RolloutPlan, storage:
 
   if (splits && ff) {
     splits.clear();
-    splits.update(ff.d, [], ff.t);
+    splits.update(ff.d || [], [], ff.t);
   }
 
   if (rbSegments && rbs) {
     rbSegments.clear();
-    rbSegments.update(rbs.d, [], rbs.t);
+    rbSegments.update(rbs.d || [], [], rbs.t);
   }
 
   const segmentChanges = rolloutPlan.segmentChanges;
diff --git a/src/sync/polling/updaters/splitChangesUpdater.ts b/src/sync/polling/updaters/splitChangesUpdater.ts
@@ -173,15 +173,15 @@ export function splitChangesUpdaterFactory(
           let updatedFlags: string[] = [];
           let ffUpdate: MaybeThenable<boolean> = false;
           if (splitChanges.ff) {
-            const { added, removed, names } = computeMutation(splitChanges.ff.d, usedSegments, splitFiltersValidation);
+            const { added, removed, names } = computeMutation(splitChanges.ff.d || [], usedSegments, splitFiltersValidation);
             updatedFlags = names;
             log.debug(SYNC_SPLITS_UPDATE, [added.length, removed.length]);
             ffUpdate = splits.update(added, removed, splitChanges.ff.t);
           }
 
           let rbsUpdate: MaybeThenable<boolean> = false;
           if (splitChanges.rbs) {
-            const { added, removed } = computeMutation(splitChanges.rbs.d, usedSegments);
+            const { added, removed } = computeMutation(splitChanges.rbs.d || [], usedSegments);
             log.debug(SYNC_RBS_UPDATE, [added.length, removed.length]);
             rbsUpdate = rbSegments.update(added, removed, splitChanges.rbs.t);
           }
diff --git a/src/utils/lang/__tests__/sets.spec.ts b/src/utils/lang/__tests__/sets.spec.ts
@@ -23,4 +23,6 @@ test('returnDifference', () => {
   expect(returnDifference([], [])).toEqual([]);
   expect(returnDifference(list, [])).toEqual(list);
   expect(returnDifference([], list2)).toEqual([]);
+
+  expect(returnDifference(undefined, null)).toEqual([]);
 });
diff --git a/src/utils/lang/sets.ts b/src/utils/lang/sets.ts
@@ -12,6 +12,8 @@ export function returnSetsUnion<T>(set: Set<T>, set2: Set<T>): Set<T> {
   return new Set(setToArray(set).concat(setToArray(set2)));
 }
 
-export function returnDifference<T>(list: T[] = [], list2: T[] = []): T[] {
-  return list.filter(item => list2.indexOf(item) === -1);
+export function returnDifference<T>(list1?: T[] | null, list2?: T[] | null): T[] {
+  list1 = list1 || [];
+  list2 = list2 || [];
+  return list1.filter(item => list2!.indexOf(item) === -1);
 }

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@splitsoftware/splitio-commons",`
`3`		`- "version": "2.12.0",`
	`3`	`+ "version": "2.12.1",`
`4`	`4`	`"description": "Split JavaScript SDK common components",`
`5`	`5`	`"main": "cjs/index.js",`
`6`	`6`	`"module": "esm/index.js",`
Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,7 @@ export class SplitsCacheInLocal extends AbstractSplitsCacheSync {`
`205`	`205`	`});`
`206`	`206`	`}`
`207`	`207`
`208`		`- private removeFromFlagSets(featureFlagName: string, flagSets?: string[]) {`
	`208`	`+ private removeFromFlagSets(featureFlagName: string, flagSets?: string[] \| null) {`
`209`	`209`	`if (!flagSets) return;`
`210`	`210`
`211`	`211`	`flagSets.forEach(flagSet => {`
Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ export class SplitsCacheInMemory extends AbstractSplitsCacheSync {`
`114`	`114`	`});`
`115`	`115`	`}`
`116`	`116`
`117`		`- private removeFromFlagSets(featureFlagName: string, flagSets: string[] \| undefined) {`
	`117`	`+ private removeFromFlagSets(featureFlagName: string, flagSets?: string[] \| null) {`
`118`	`118`	`if (!flagSets) return;`
`119`	`119`	`flagSets.forEach(flagSet => {`
`120`	`120`	`this.removeNames(flagSet, featureFlagName);`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ export class SplitsCacheInRedis extends AbstractSplitsCacheAsync {`
`59`	`59`	`return this.redis.incr(ttKey);`
`60`	`60`	`}`
`61`	`61`
`62`		`- private _updateFlagSets(featureFlagName: string, flagSetsOfRemovedFlag?: string[], flagSetsOfAddedFlag?: string[]) {`
	`62`	`+ private _updateFlagSets(featureFlagName: string, flagSetsOfRemovedFlag?: string[] \| null, flagSetsOfAddedFlag?: string[] \| null) {`
`63`	`63`	`const removeFromFlagSets = returnDifference(flagSetsOfRemovedFlag, flagSetsOfAddedFlag);`
`64`	`64`
`65`	`65`	`let addToFlagSets = returnDifference(flagSetsOfAddedFlag, flagSetsOfRemovedFlag);`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ export class SplitsCachePluggable extends AbstractSplitsCacheAsync {`
`43`	`43`	`return this.wrapper.incr(ttKey);`
`44`	`44`	`}`
`45`	`45`
`46`		`- private _updateFlagSets(featureFlagName: string, flagSetsOfRemovedFlag?: string[], flagSetsOfAddedFlag?: string[]) {`
	`46`	`+ private _updateFlagSets(featureFlagName: string, flagSetsOfRemovedFlag?: string[] \| null, flagSetsOfAddedFlag?: string[] \| null) {`
`47`	`47`	`const removeFromFlagSets = returnDifference(flagSetsOfRemovedFlag, flagSetsOfAddedFlag);`
`48`	`48`
`49`	`49`	`let addToFlagSets = returnDifference(flagSetsOfAddedFlag, flagSetsOfRemovedFlag);`
Original file line number	Diff line number	Diff line change
`@@ -35,12 +35,12 @@ export function setRolloutPlan(log: ILogger, rolloutPlan: RolloutPlan, storage:`
`35`	`35`
`36`	`36`	`if (splits && ff) {`
`37`	`37`	`splits.clear();`
`38`		`- splits.update(ff.d, [], ff.t);`
	`38`	`+ splits.update(ff.d \|\| [], [], ff.t);`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`if (rbSegments && rbs) {`
`42`	`42`	`rbSegments.clear();`
`43`		`- rbSegments.update(rbs.d, [], rbs.t);`
	`43`	`+ rbSegments.update(rbs.d \|\| [], [], rbs.t);`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`const segmentChanges = rolloutPlan.segmentChanges;`