Skip to content

Commit 5135786

Browse files
authored
Merge pull request #242 from splitio/fix/php84-nullable-type-deprecation
Adding support for PHP 8.5
2 parents 3e1d3fa + 02421e0 commit 5135786

13 files changed

Lines changed: 224 additions & 43 deletions

File tree

.github/workflows/ci.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ jobs:
3131
- '8.1'
3232
- '8.2'
3333
- '8.3'
34+
- '8.4'
35+
- '8.5'
3436
steps:
3537
- name: Checkout code
3638
uses: actions/checkout@v3
@@ -60,7 +62,7 @@ jobs:
6062

6163
- name: SonarQube Scan (Push)
6264
if: matrix.version == '8.2' && github.event_name == 'push'
63-
uses: SonarSource/sonarcloud-github-action@v1.9
65+
uses: SonarSource/sonarcloud-github-action@v3
6466
env:
6567
SONAR_TOKEN: ${{ secrets.SONARQUBE_TOKEN }}
6668
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -72,7 +74,7 @@ jobs:
7274
7375
- name: SonarQube Scan (Pull Request)
7476
if: matrix.version == '8.2' && github.event_name == 'pull_request'
75-
uses: SonarSource/sonarcloud-github-action@v1.9
77+
uses: SonarSource/sonarcloud-github-action@v3
7678
env:
7779
SONAR_TOKEN: ${{ secrets.SONARQUBE_TOKEN }}
7880
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

CHANGES.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
7.4.0 (Apr 15, 2026)
2+
- Added support for PHP 8.5 version, removing deprecated warning messages.
3+
14
7.3.0 (May 14, 2024)
25
- Added support for targeting rules based on semantic versions (https://semver.org/).
36
- Added the logic to handle correctly when the SDK receives an unsupported Matcher type.

LICENSE.txt

Lines changed: 171 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,171 @@
1+
Apache License
2+
Version 2.0, January 2004
3+
http://www.apache.org/licenses/
4+
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
5+
1. Definitions.
6+
"License" shall mean the terms and conditions for use, reproduction,
7+
and distribution as defined by Sections 1 through 9 of this document.
8+
"Licensor" shall mean the copyright owner or entity authorized by
9+
the copyright owner that is granting the License.
10+
"Legal Entity" shall mean the union of the acting entity and all
11+
other entities that control, are controlled by, or are under common
12+
control with that entity. For the purposes of this definition,
13+
"control" means (i) the power, direct or indirect, to cause the
14+
direction or management of such entity, whether by contract or
15+
otherwise, or (ii) ownership of fifty percent (50%) or more of the
16+
outstanding shares, or (iii) beneficial ownership of such entity.
17+
"You" (or "Your") shall mean an individual or Legal Entity
18+
exercising permissions granted by this License.
19+
"Source" form shall mean the preferred form for making modifications,
20+
including but not limited to software source code, documentation
21+
source, and configuration files.
22+
"Object" form shall mean any form resulting from mechanical
23+
transformation or translation of a Source form, including but
24+
not limited to compiled object code, generated documentation,
25+
and conversions to other media types.
26+
"Work" shall mean the work of authorship, whether in Source or
27+
Object form, made available under the License, as indicated by a
28+
copyright notice that is included in or attached to the work
29+
(an example is provided in the Appendix below).
30+
"Derivative Works" shall mean any work, whether in Source or Object
31+
form, that is based on (or derived from) the Work and for which the
32+
editorial revisions, annotations, elaborations, or other modifications
33+
represent, as a whole, an original work of authorship. For the purposes
34+
of this License, Derivative Works shall not include works that remain
35+
separable from, or merely link (or bind by name) to the interfaces of,
36+
the Work and Derivative Works thereof.
37+
"Contribution" shall mean any work of authorship, including
38+
the original version of the Work and any modifications or additions
39+
to that Work or Derivative Works thereof, that is intentionally
40+
submitted to Licensor for inclusion in the Work by the copyright owner
41+
or by an individual or Legal Entity authorized to submit on behalf of
42+
the copyright owner. For the purposes of this definition, "submitted"
43+
means any form of electronic, verbal, or written communication sent
44+
to the Licensor or its representatives, including but not limited to
45+
communication on electronic mailing lists, source code control systems,
46+
and issue tracking systems that are managed by, or on behalf of, the
47+
Licensor for the purpose of discussing and improving the Work, but
48+
excluding communication that is conspicuously marked or otherwise
49+
designated in writing by the copyright owner as "Not a Contribution."
50+
"Contributor" shall mean Licensor and any individual or Legal Entity
51+
on behalf of whom a Contribution has been received by Licensor and
52+
subsequently incorporated within the Work.
53+
2. Grant of Copyright License. Subject to the terms and conditions of
54+
this License, each Contributor hereby grants to You a perpetual,
55+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
56+
copyright license to reproduce, prepare Derivative Works of,
57+
publicly display, publicly perform, sublicense, and distribute the
58+
Work and such Derivative Works in Source or Object form.
59+
3. Grant of Patent License. Subject to the terms and conditions of
60+
this License, each Contributor hereby grants to You a perpetual,
61+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
62+
(except as stated in this section) patent license to make, have made,
63+
use, offer to sell, sell, import, and otherwise transfer the Work,
64+
where such license applies only to those patent claims licensable
65+
by such Contributor that are necessarily infringed by their
66+
Contribution(s) alone or by combination of their Contribution(s)
67+
with the Work to which such Contribution(s) was submitted. If You
68+
institute patent litigation against any entity (including a
69+
cross-claim or counterclaim in a lawsuit) alleging that the Work
70+
or a Contribution incorporated within the Work constitutes direct
71+
or contributory patent infringement, then any patent licenses
72+
granted to You under this License for that Work shall terminate
73+
as of the date such litigation is filed.
74+
4. Redistribution. You may reproduce and distribute copies of the
75+
Work or Derivative Works thereof in any medium, with or without
76+
modifications, and in Source or Object form, provided that You
77+
meet the following conditions:
78+
(a) You must give any other recipients of the Work or
79+
Derivative Works a copy of this License; and
80+
(b) You must cause any modified files to carry prominent notices
81+
stating that You changed the files; and
82+
(c) You must retain, in the Source form of any Derivative Works
83+
that You distribute, all copyright, patent, trademark, and
84+
attribution notices from the Source form of the Work,
85+
excluding those notices that do not pertain to any part of
86+
the Derivative Works; and
87+
(d) If the Work includes a "NOTICE" text file as part of its
88+
distribution, then any Derivative Works that You distribute must
89+
include a readable copy of the attribution notices contained
90+
within such NOTICE file, excluding those notices that do not
91+
pertain to any part of the Derivative Works, in at least one
92+
of the following places: within a NOTICE text file distributed
93+
as part of the Derivative Works; within the Source form or
94+
documentation, if provided along with the Derivative Works; or,
95+
within a display generated by the Derivative Works, if and
96+
wherever such third-party notices normally appear. The contents
97+
of the NOTICE file are for informational purposes only and
98+
do not modify the License. You may add Your own attribution
99+
notices within Derivative Works that You distribute, alongside
100+
or as an addendum to the NOTICE text from the Work, provided
101+
that such additional attribution notices cannot be construed
102+
as modifying the License.
103+
You may add Your own copyright statement to Your modifications and
104+
may provide additional or different license terms and conditions
105+
for use, reproduction, or distribution of Your modifications, or
106+
for any such Derivative Works as a whole, provided Your use,
107+
reproduction, and distribution of the Work otherwise complies with
108+
the conditions stated in this License.
109+
5. Submission of Contributions. Unless You explicitly state otherwise,
110+
any Contribution intentionally submitted for inclusion in the Work
111+
by You to the Licensor shall be under the terms and conditions of
112+
this License, without any additional terms or conditions.
113+
Notwithstanding the above, nothing herein shall supersede or modify
114+
the terms of any separate license agreement you may have executed
115+
with Licensor regarding such Contributions.
116+
6. Trademarks. This License does not grant permission to use the trade
117+
names, trademarks, service marks, or product names of the Licensor,
118+
except as required for reasonable and customary use in describing the
119+
origin of the Work and reproducing the content of the NOTICE file.
120+
7. Disclaimer of Warranty. Unless required by applicable law or
121+
agreed to in writing, Licensor provides the Work (and each
122+
Contributor provides its Contributions) on an "AS IS" BASIS,
123+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
124+
implied, including, without limitation, any warranties or conditions
125+
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
126+
PARTICULAR PURPOSE. You are solely responsible for determining the
127+
appropriateness of using or redistributing the Work and assume any
128+
risks associated with Your exercise of permissions under this License.
129+
8. Limitation of Liability. In no event and under no legal theory,
130+
whether in tort (including negligence), contract, or otherwise,
131+
unless required by applicable law (such as deliberate and grossly
132+
negligent acts) or agreed to in writing, shall any Contributor be
133+
liable to You for damages, including any direct, indirect, special,
134+
incidental, or consequential damages of any character arising as a
135+
result of this License or out of the use or inability to use the
136+
Work (including but not limited to damages for loss of goodwill,
137+
work stoppage, computer failure or malfunction, or any and all
138+
other commercial damages or losses), even if such Contributor
139+
has been advised of the possibility of such damages.
140+
9. Accepting Warranty or Additional Liability. While redistributing
141+
the Work or Derivative Works thereof, You may choose to offer,
142+
and charge a fee for, acceptance of support, warranty, indemnity,
143+
or other liability obligations and/or rights consistent with this
144+
License. However, in accepting such obligations, You may act only
145+
on Your own behalf and on Your sole responsibility, not on behalf
146+
of any other Contributor, and only if You agree to indemnify,
147+
defend, and hold each Contributor harmless for any liability
148+
incurred by, or claims asserted against, such Contributor by reason
149+
of your accepting any such warranty or additional liability.
150+
END OF TERMS AND CONDITIONS
151+
152+
APPENDIX: How to apply the Apache License to your work.
153+
To apply the Apache License to your work, attach the following
154+
boilerplate notice, with the fields enclosed by brackets "[]"
155+
replaced with your own identifying information. (Don't include
156+
the brackets!) The text should be enclosed in the appropriate
157+
comment syntax for the file format. We also recommend that a
158+
file or class name and description of purpose be included on the
159+
same "printed page" as the copyright notice for easier
160+
identification within third-party archives.
161+
Copyright [yyyy] [name of copyright owner]
162+
163+
Licensed under the Apache License, Version 2.0 (the "License");
164+
you may not use this file except in compliance with the License.
165+
You may obtain a copy of the License at
166+
http://www.apache.org/licenses/LICENSE-2.0
167+
Unless required by applicable law or agreed to in writing, software
168+
distributed under the License is distributed on an "AS IS" BASIS,
169+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
170+
See the License for the specific language governing permissions and
171+
limitations under the License.

NOTICE.txt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
Harness Feature Management JavaScript SDK Copyright 2024-2026 Harness Inc.
2+
3+
This product includes software developed at Harness Inc. (https://harness.io/).
4+
5+
This product includes software originally developed by Split Software, Inc. (https://www.split.io/). Copyright 2015-2024 Split Software, Inc.

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@
88
This SDK is designed to work with Split, the platform for controlled rollouts, which serves features to your users via feature flags to manage your complete customer experience.
99

1010
## Compatibility
11-
This SDK is compatible with PHP 7.3 and above.
11+
This SDK is compatible with PHP 7.3 and above, including PHP 8.4 and 8.5.
1212

1313
## Getting started
1414
Below is a simple example that describes the instantiation and most basic usage of our SDK.
15-
Keep in mind that since PHP does not have the ability to share memory between processes the use of the [split-synchronizer](https://help.split.io/hc/en-us/articles/360019686092-Split-Synchronizer) is mandatory for this SDK.
15+
Keep in mind that since PHP does not have the ability to share memory between processes the use of the [split-synchronizer](https://developer.harness.io/docs/feature-management-experimentation/sdks-and-infrastructure/optional-infra/split-synchronizer/) is mandatory for this SDK.
1616

1717
```php
1818
<?php
@@ -31,7 +31,7 @@ if ($treatment === 'on') {
3131
}
3232
```
3333

34-
Please refer to [our official docs](https://help.split.io/hc/en-us/articles/360020350372-PHP-SDK) to learn about all the functionality provided by our SDK and the configuration options available for tailoring it to your current application setup.
34+
Please refer to [our official docs](https://developer.harness.io/docs/feature-management-experimentation/sdks-and-infrastructure/server-side-sdks/php-sdk) to learn about all the functionality provided by our SDK and the configuration options available for tailoring it to your current application setup.
3535

3636
## Submitting issues
3737

src/SplitIO/Component/Log/Logger.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class Logger extends LoggerTrait
3838
* Logger constructor
3939
* @param LogHandlerInterface|null $handler
4040
*/
41-
public function __construct(LogHandlerInterface $handler = null, $level = LogLevel::WARNING)
41+
public function __construct(?LogHandlerInterface $handler = null, $level = LogLevel::WARNING)
4242
{
4343
$this->logLevel = $this->logLevels[$level];
4444

src/SplitIO/Engine.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class Engine
2121
* @param array|null $attributes
2222
* @return array
2323
*/
24-
public static function getTreatment($matchingKey, $bucketingKey, SplitGrammar $split, array $attributes = null)
24+
public static function getTreatment($matchingKey, $bucketingKey, SplitGrammar $split, ?array $attributes = null)
2525
{
2626
if ($bucketingKey === null) {
2727
$bucketingKey = $matchingKey;

src/SplitIO/Grammar/Condition.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public function __construct(array $condition)
6868
* @param array|null $attributes
6969
* @return bool
7070
*/
71-
public function match($key, array $attributes = null, $bucketingKey = null)
71+
public function match($key, ?array $attributes = null, $bucketingKey = null)
7272
{
7373
$eval = array();
7474
foreach ($this->matcherGroup as $matcher) {

0 commit comments

Comments
 (0)