Polishing

Author: EmilianoSanchez

.github/workflows/ci-cd.yml

@@ -77,7 +77,7 @@ jobs:
             -Dsonar.pullrequest.base=${{ github.event.pull_request.base.ref }}
 
       - name: Store assets
-        if: github.event_name == 'push' && (github.ref == 'refs/heads/master' || github.ref == 'refs/heads/add_SplitFactoryProvider')
+        if: github.event_name == 'push' && (github.ref == 'refs/heads/master' || github.ref == 'refs/heads/development')
         uses: actions/upload-artifact@v3
         with:
           name: assets
@@ -88,7 +88,7 @@ jobs:
     name: Upload assets
     runs-on: ubuntu-latest
     needs: build
-    if: github.event_name == 'push' && github.ref == 'refs/heads/add_SplitFactoryProvider'
+    if: github.event_name == 'push' && github.ref == 'refs/heads/development'
     strategy:
       matrix:
         environment:

src/SplitFactoryProvider.tsx

@@ -12,7 +12,7 @@ import { DEFAULT_UPDATE_OPTIONS } from './useSplitClient';
  * since they access the Split Context and its elements (factory, clients, etc).
  *
  * NOTE: Either pass a factory instance or a config object. If both are passed, the config object will be ignored.
- * Pass a reference to the config or factory object rather than a new instance on each render, to avoid unnecessary props changes and SDK reinitializations.
+ * Pass the same reference to the config or factory object rather than a new instance on each render, to avoid unnecessary props changes and SDK reinitializations.
  *
  * @see {@link https://help.split.io/hc/en-us/articles/360038825091-React-SDK#2-instantiate-the-sdk-and-create-a-new-split-client}
  */

src/constants.ts

@@ -16,7 +16,7 @@ export const CONTROL_WITH_CONFIG: SplitIO.TreatmentWithConfig = {
 // Warning and error messages
 export const WARN_SF_CONFIG_AND_FACTORY: string = '[WARN]  Both a config and factory props were provided to SplitFactoryProvider. Config prop will be ignored.';
 
-// @TODO remove with SplitFactory component in next major version
+// @TODO remove with SplitFactory component in next major version. SplitFactoryProvider can accept no props and eventually only an initialState
 export const ERROR_SF_NO_CONFIG_AND_FACTORY: string = '[ERROR] SplitFactory must receive either a Split config or a Split factory as props.';
 
 export const EXCEPTION_NO_REACT_OR_CREATECONTEXT: string = 'React library is not available or its version is not supported. Check that it is properly installed or imported. Split SDK requires version 16.3.0+ of React.';