Skip to content

Commit 3d1073a

Browse files
committed
Add ECR
1 parent 875160d commit 3d1073a

7 files changed

Lines changed: 41 additions & 45 deletions

File tree

.github/workflows/docker.yml

Lines changed: 24 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,19 @@ name: docker
33
on:
44
push:
55
branches:
6-
- master
6+
- main
77
pull_request:
88
branches:
9-
- master
9+
- main
1010

1111
concurrency:
1212
group: ${{ github.workflow }}-${{ github.event_name == 'push' && github.run_number || github.event.pull_request.number }}
1313
cancel-in-progress: true
1414

15+
permissions:
16+
contents: read
17+
id-token: write
18+
1519
jobs:
1620
docker:
1721
name: Build Docker image
@@ -28,51 +32,32 @@ jobs:
2832
- name: Set up Docker Buildx
2933
uses: docker/setup-buildx-action@v3
3034

31-
- name: Login to Artifactory
32-
if: ${{ github.event_name == 'push' }}
33-
uses: docker/login-action@v3
34-
with:
35-
registry: splitio-docker-dev.jfrog.io
36-
username: ${{ secrets.ARTIFACTORY_DOCKER_USER }}
37-
password: ${{ secrets.ARTIFACTORY_DOCKER_PASS }}
38-
3935
- name: Create build version
4036
run: echo "BUILD_VERSION=$(cat package.json | grep version | head -1 | awk '{ print $2 }' | sed 's/[\",]//g' | tr -d '[[:space:]]')" >> $GITHUB_ENV
4137

42-
- name: Docker build
43-
uses: docker/build-push-action@v6
38+
- name: Login to Dockerhub
39+
uses: docker/login-action@v3
4440
with:
45-
context: .
46-
push: ${{ github.event_name == 'push' }}
47-
platforms: linux/amd64,linux/arm64
48-
tags: splitio-docker-dev.jfrog.io/${{ github.event.repository.name }}:${{ env.BUILD_VERSION}},splitio-docker-dev.jfrog.io/${{ github.event.repository.name }}:latest
41+
username: ${{ vars.DOCKERHUB_USERNAME }}
42+
password: ${{ secrets.DOCKERHUB_RO_TOKEN }}
4943

50-
lacework:
51-
name: Scan Docker image
52-
if: ${{ github.event_name == 'pull_request' }}
53-
runs-on: ubuntu-latest
54-
steps:
55-
- name: Checkout code
56-
uses: actions/checkout@v4
44+
- name: Configure AWS credentials
45+
if: ${{ github.event_name == 'push' }}
46+
uses: aws-actions/configure-aws-credentials@v4
47+
with:
48+
role-to-assume: ${{ vars.ECR_TESTING_ROLE_ARN }}
49+
aws-region: us-east-1
5750

58-
- name: Create build version
59-
run: echo "BUILD_VERSION=$(cat package.json | grep version | head -1 | awk '{ print $2 }' | sed 's/[\",]//g' | tr -d '[[:space:]]')" >> $GITHUB_ENV
51+
- name: Login to Amazon ECR
52+
if: ${{ github.event_name == 'push' }}
53+
uses: aws-actions/amazon-ecr-login@v2
6054

6155
- name: Docker build
6256
uses: docker/build-push-action@v6
6357
with:
6458
context: .
65-
push: false
66-
tags: splitio-docker-dev.jfrog.io/${{ github.event.repository.name }}:${{ env.BUILD_VERSION}}
67-
build-args: |
68-
ARTIFACTORY_USER=${{ secrets.ARTIFACTORY_USER }}
69-
ARTIFACTORY_TOKEN=${{ secrets.ARTIFACTORY_TOKEN }}
70-
71-
- name: Scan container using Lacework
72-
uses: lacework/lw-scanner-action@v1.4.5
73-
with:
74-
LW_ACCOUNT_NAME: ${{ secrets.LW_ACCOUNT_NAME }}
75-
LW_ACCESS_TOKEN: ${{ secrets.LW_ACCESS_TOKEN }}
76-
IMAGE_NAME: splitio-docker-dev.jfrog.io/${{ github.event.repository.name }}
77-
IMAGE_TAG: ${{ env.BUILD_VERSION}}
78-
SAVE_RESULTS_IN_LACEWORK: true
59+
push: ${{ github.event_name == 'push' }}
60+
platforms: linux/amd64,linux/arm64
61+
tags: |
62+
${{ vars.ECR_TESTING_URL }}/${{ github.event.repository.name }}:${{ env.BUILD_VERSION}}
63+
${{ vars.ECR_TESTING_URL }}/${{ github.event.repository.name }}:latest

.github/workflows/unstable.yml

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,29 @@ name: unstable
33
on:
44
push:
55
branches-ignore:
6-
- master
6+
- main
77

88
jobs:
99
push-docker-image:
1010
name: Build and Push Docker Image
1111
runs-on: ubuntu-latest
1212
steps:
13-
- name: Login to DockerHub
13+
- name: Login to Dockerhub
1414
uses: docker/login-action@v3
1515
with:
16-
registry: splitio-docker-dev.jfrog.io
17-
username: ${{ secrets.ARTIFACTORY_DOCKER_USER }}
18-
password: ${{ secrets.ARTIFACTORY_DOCKER_PASS }}
16+
username: ${{ vars.DOCKERHUB_USERNAME }}
17+
password: ${{ secrets.DOCKERHUB_RO_TOKEN }}
18+
19+
- name: Configure AWS credentials
20+
if: ${{ github.event_name == 'push' }}
21+
uses: aws-actions/configure-aws-credentials@v4
22+
with:
23+
role-to-assume: ${{ vars.ECR_TESTING_ROLE_ARN }}
24+
aws-region: us-east-1
25+
26+
- name: Login to Amazon ECR
27+
if: ${{ github.event_name == 'push' }}
28+
uses: aws-actions/amazon-ecr-login@v2
1929

2030
- name: Checkout code
2131
uses: actions/checkout@v4
@@ -37,4 +47,5 @@ jobs:
3747
context: .
3848
push: true
3949
platforms: linux/amd64,linux/arm64
40-
tags: splitio-docker-dev.jfrog.io/${{ github.event.repository.name }}:${{ env.SHORT_SHA}}
50+
tags: |
51+
${{ vars.ECR_TESTING_URL }}/${{ github.event.repository.name }}:${{ env.SHORT_SHA}}
File renamed without changes.

0 commit comments

Comments
 (0)