Skip to content

Commit c2f32f2

Browse files
update commons version and fix post
1 parent 9910639 commit c2f32f2

File tree

3 files changed

+20
-13
lines changed

3 files changed

+20
-13
lines changed

client/client.router.js

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,12 @@ const fwdPropertiesFromPost = function parsePropertiesMiddleware(req, res, next)
194194
next();
195195
};
196196

197+
const fwdImpressionsDisabledFromPost = function parseImpressionsDisabledMiddleware(req, res, next) {
198+
const impressionsDisabled = req.body.impressionsDisabled;
199+
if (impressionsDisabled !== undefined) req.query['impressions-disabled'] = req.body.impressionsDisabled.toString();
200+
next();
201+
};
202+
197203
const handleBodyParserErr = function handleBodyParserErr(error, req, res, next) {
198204
if (error) {
199205
return res
@@ -218,14 +224,14 @@ router.get('/get-all-treatments-with-config', allTreatmentValidation, clientCont
218224

219225
// Getting treatments as POST's for big attribute sets
220226
const JSON_PARSE_OPTS = { limit: '300kb' };
221-
router.post('/get-treatment',express.json(JSON_PARSE_OPTS), fwdAttributesFromPost, fwdPropertiesFromPost, handleBodyParserErr, treatmentValidation, clientController.getTreatment);
222-
router.post('/get-treatment-with-config', express.json(JSON_PARSE_OPTS), fwdAttributesFromPost, fwdPropertiesFromPost, handleBodyParserErr, treatmentValidation, clientController.getTreatmentWithConfig);
223-
router.post('/get-treatments', express.json(JSON_PARSE_OPTS), fwdAttributesFromPost, fwdPropertiesFromPost, handleBodyParserErr, treatmentsValidation, clientController.getTreatments);
224-
router.post('/get-treatments-with-config', express.json(JSON_PARSE_OPTS), fwdAttributesFromPost, fwdPropertiesFromPost, handleBodyParserErr, treatmentsValidation, clientController.getTreatmentsWithConfig);
225-
router.post('/get-treatments-by-sets', express.json(JSON_PARSE_OPTS), fwdAttributesFromPost, fwdPropertiesFromPost, handleBodyParserErr, flagSetsValidation, clientController.getTreatmentsByFlagSets);
226-
router.post('/get-treatments-with-config-by-sets', express.json(JSON_PARSE_OPTS), fwdAttributesFromPost, fwdPropertiesFromPost, handleBodyParserErr, flagSetsValidation, clientController.getTreatmentsWithConfigByFlagSets);
227-
router.post('/get-all-treatments', express.json(JSON_PARSE_OPTS), fwdAttributesFromPost, fwdPropertiesFromPost, handleBodyParserErr, allTreatmentValidation, clientController.getAllTreatments);
228-
router.post('/get-all-treatments-with-config', express.json(JSON_PARSE_OPTS), fwdAttributesFromPost, fwdPropertiesFromPost, handleBodyParserErr, allTreatmentValidation, clientController.getAllTreatmentsWithConfig);
227+
router.post('/get-treatment',express.json(JSON_PARSE_OPTS), fwdAttributesFromPost, fwdPropertiesFromPost, fwdImpressionsDisabledFromPost, handleBodyParserErr, treatmentValidation, clientController.getTreatment);
228+
router.post('/get-treatment-with-config', express.json(JSON_PARSE_OPTS), fwdAttributesFromPost, fwdPropertiesFromPost, fwdImpressionsDisabledFromPost, handleBodyParserErr, treatmentValidation, clientController.getTreatmentWithConfig);
229+
router.post('/get-treatments', express.json(JSON_PARSE_OPTS), fwdAttributesFromPost, fwdPropertiesFromPost, fwdImpressionsDisabledFromPost, handleBodyParserErr, treatmentsValidation, clientController.getTreatments);
230+
router.post('/get-treatments-with-config', express.json(JSON_PARSE_OPTS), fwdAttributesFromPost, fwdPropertiesFromPost, fwdImpressionsDisabledFromPost, handleBodyParserErr, treatmentsValidation, clientController.getTreatmentsWithConfig);
231+
router.post('/get-treatments-by-sets', express.json(JSON_PARSE_OPTS), fwdAttributesFromPost, fwdPropertiesFromPost, fwdImpressionsDisabledFromPost, handleBodyParserErr, flagSetsValidation, clientController.getTreatmentsByFlagSets);
232+
router.post('/get-treatments-with-config-by-sets', express.json(JSON_PARSE_OPTS), fwdAttributesFromPost, fwdPropertiesFromPost, fwdImpressionsDisabledFromPost, handleBodyParserErr, flagSetsValidation, clientController.getTreatmentsWithConfigByFlagSets);
233+
router.post('/get-all-treatments', express.json(JSON_PARSE_OPTS), fwdAttributesFromPost, fwdPropertiesFromPost, fwdImpressionsDisabledFromPost, handleBodyParserErr, allTreatmentValidation, clientController.getAllTreatments);
234+
router.post('/get-all-treatments-with-config', express.json(JSON_PARSE_OPTS), fwdAttributesFromPost, fwdPropertiesFromPost, fwdImpressionsDisabledFromPost, handleBodyParserErr, allTreatmentValidation, clientController.getAllTreatmentsWithConfig);
229235

230236
// Other methods
231237
router.get('/track', trackValidation, clientController.track);

package-lock.json

Lines changed: 5 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"test": "NODE_ENV=test jest"
4242
},
4343
"dependencies": {
44-
"@splitsoftware/splitio-commons": "2.9.1-rc.2",
44+
"@splitsoftware/splitio-commons": "2.10.0",
4545
"bloom-filters": "^3.0.4",
4646
"config": "^3.3.9",
4747
"js-yaml": "^4.1.0",

0 commit comments

Comments
 (0)