update properties validation message

Author: ZamoraEmmanuel

client/__tests__/track.test.js

@@ -145,7 +145,7 @@ describe('track', () => {
 
   test('should be 400 if properties is invalid', async () => {
     const expected = [
-      'properties must be a plain object.'
+      'properties must be a plain object  with only boolean, string, number or null values..'
     ];
     const response = await request(app)
       .get('/client/track?key=my-key&event-type=my-event&traffic-type=my-traffic&value=1&properties=lalala')
@@ -158,7 +158,7 @@ describe('track', () => {
       'key too long, key must be 250 characters or less.',
       'you passed "@!test", event-type must adhere to the regular expression /^[a-zA-Z0-9][-_.:a-zA-Z0-9]{0,79}$/g. This means an event_type must be alphanumeric, cannot be more than 80 characters long, and can only include a dash, underscore, period, or colon as separators of alphanumeric characters.',
       'you passed an empty traffic-type, traffic-type must be a non-empty string.',
-      'properties must be a plain object.',
+      'properties must be a plain object  with only boolean, string, number or null values..',
       'value must be null or number.'
     ];
     const key = getLongKey();

utils/inputValidation/__tests__/properties.test.js

@@ -2,7 +2,7 @@ const { validateProperties, validateEvaluationOptions } = require('../properties
 
 describe('validateProperties', () => {
   test('should return error on invalid properties', done => {
-    const expected = 'properties must be a plain object.';
+    const expected = 'properties must be a plain object  with only boolean, string, number or null values..';
     const result = validateProperties('test');
     expect(result).toHaveProperty('valid', false);
     expect(result).toHaveProperty('error', expected);
@@ -11,7 +11,7 @@ describe('validateProperties', () => {
   });
 
   test('should return error on invalid properties 2', done => {
-    const expected = 'properties must be a plain object.';
+    const expected = 'properties must be a plain object  with only boolean, string, number or null values..';
     const result = validateProperties('[]');
     expect(result).toHaveProperty('valid', false);
     expect(result).toHaveProperty('error', expected);
@@ -20,7 +20,7 @@ describe('validateProperties', () => {
   });
 
   test('should return error on invalid properties 3', done => {
-    const expected = 'properties must be a plain object.';
+    const expected = 'properties must be a plain object  with only boolean, string, number or null values..';
     const result = validateProperties('true');
     expect(result).toHaveProperty('valid', false);
     expect(result).toHaveProperty('error', expected);
@@ -108,7 +108,7 @@ describe('validateEvaluationOptions', () => {
   });
 
   test('should return error if options.properties is not valid', done => {
-    const expected = 'properties must be a plain object.';
+    const expected = 'properties must be a plain object  with only boolean, string, number or null values..';
     const result = validateEvaluationOptions('{"properties": "not-an-object"}');
     expect(result).toHaveProperty('valid', false);
     expect(result).toHaveProperty('error', expected);

utils/inputValidation/properties.js

@@ -10,11 +10,11 @@ function validateProperties(maybeProperties) {
   try {
     properties = isString(maybeProperties) ? JSON.parse(maybeProperties) : maybeProperties;
     if (!isObject(properties)) {
-      return errorWrapper('properties must be a plain object.');
+      return errorWrapper('properties must be a plain object  with only boolean, string, number or null values..');
     }
     return okWrapper(properties);
   } catch (e) {
-    return errorWrapper('properties must be a plain object.');
+    return errorWrapper('properties must be a plain object  with only boolean, string, number or null values..');
   }
 }