breaking change: replace btool with splunk rest

Author: sgoral-splunk

solnlib/_settings.py

@@ -0,0 +1,18 @@
+#
+# Copyright 2025 Splunk Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+"""This module provide settings that can be used to disable/switch features."""
+
+use_btool = False

solnlib/credentials.py

@@ -16,23 +16,19 @@
 
 """This module contains Splunk credential related interfaces."""
 
-import json
 import re
 import warnings
 from typing import Dict, List
 
 from splunklib import binding, client
 
 from . import splunk_rest_client as rest_client
-from .net_utils import validate_scheme_host_port
-from .splunkenv import get_splunkd_access_info
 from .utils import retry
 
 __all__ = [
     "CredentialException",
     "CredentialNotExistException",
     "CredentialManager",
-    "get_session_key",
 ]
 
 
@@ -339,56 +335,3 @@ def _get_all_passwords(self) -> List[Dict[str, str]]:
         )
         passwords = self._storage_passwords.list(count=-1)
         return self._get_clear_passwords(passwords)
-
-
-@retry(exceptions=[binding.HTTPError])
-def get_session_key(
-    username: str,
-    password: str,
-    scheme: str = None,
-    host: str = None,
-    port: int = None,
-    **context: dict,
-) -> str:
-    """Get splunkd access token.
-
-    Arguments:
-        username: The Splunk account username, which is used to authenticate the Splunk instance.
-        password: The Splunk account password.
-        scheme: (optional) The access scheme, default is None.
-        host: (optional) The host name, default is None.
-        port: (optional) The port number, default is None.
-        context: Other configurations for Splunk rest client.
-
-    Returns:
-        Splunk session key.
-
-    Raises:
-        CredentialException: If username/password are invalid.
-        ValueError: if scheme, host or port are invalid.
-
-    Examples:
-       >>> get_session_key('user', 'password')
-    """
-    validate_scheme_host_port(scheme, host, port)
-
-    if any([scheme is None, host is None, port is None]):
-        scheme, host, port = get_splunkd_access_info(use_btool=True)
-
-    uri = "{scheme}://{host}:{port}/{endpoint}".format(
-        scheme=scheme, host=host, port=port, endpoint="services/auth/login"
-    )
-    _rest_client = rest_client.SplunkRestClient(
-        None, "-", "nobody", scheme, host, port, **context
-    )
-    try:
-        response = _rest_client.http.post(
-            uri, username=username, password=password, output_mode="json"
-        )
-    except binding.HTTPError as e:
-        if e.status != 401:
-            raise
-
-        raise CredentialException("Invalid username/password.")
-
-    return json.loads(response.body.read())["sessionKey"]

solnlib/modular_input/event_writer.py

@@ -233,15 +233,13 @@ def __init__(
             scheme, host, hec_port = utils.extract_http_scheme_host_port(hec_uri)
         else:
             if not all([scheme, host, port]):
-                scheme, host, port = get_splunkd_access_info(
-                    session_key=self._session_key
-                )
+                scheme, host, port = get_splunkd_access_info(self._session_key)
             hec_port, hec_token = self._get_hec_config(
                 hec_input_name, session_key, scheme, host, port, **context
             )
 
         if global_settings_schema:
-            scheme = get_scheme_from_hec_settings(session_key=self._session_key)
+            scheme = get_scheme_from_hec_settings(self._session_key)
 
         if not context.get("pool_connections"):
             context["pool_connections"] = 10

solnlib/server_info.py

@@ -78,7 +78,7 @@ def __init__(
         """
         is_localhost = False
         if not all([scheme, host, port]) and os.environ.get("SPLUNK_HOME"):
-            scheme, host, port = get_splunkd_access_info(session_key=session_key)
+            scheme, host, port = get_splunkd_access_info(session_key)
             is_localhost = (
                 host == "localhost" or host == "127.0.0.1" or host in ("::1", "[::1]")
             )

solnlib/splunk_rest_client.py

@@ -221,7 +221,7 @@ def __init__(
         """
         # Only do splunkd URI discovery in SPLUNK env (SPLUNK_HOME is set).
         if not all([scheme, host, port]) and os.environ.get("SPLUNK_HOME"):
-            scheme, host, port = get_splunkd_access_info(session_key=session_key)
+            scheme, host, port = get_splunkd_access_info(session_key)
         if os.environ.get("SPLUNK_HOME") is None:
             if not all([scheme, host, port]):
                 raise ValueError(