Skip to content

Commit ce3cef9

Browse files
committed
fix: address PR comments
1 parent 7d959ac commit ce3cef9

File tree

5 files changed

+48
-81
lines changed

5 files changed

+48
-81
lines changed

.github/workflows/build-test-release.yml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ on:
1010
pull_request:
1111
branches: [main, develop]
1212

13+
env:
14+
PYTHON_VERSION: "3.9"
15+
POETRY_VERSION: "1.5.1"
16+
1317
jobs:
1418
meta:
1519
runs-on: ubuntu-latest
@@ -55,7 +59,7 @@ jobs:
5559
- uses: actions/checkout@v4
5660
- uses: actions/setup-python@v5
5761
with:
58-
python-version: "3.9"
62+
python-version: ${{ env.PYTHON_VERSION }}
5963
- uses: pre-commit/action@v3.0.1
6064

6165
semgrep:
@@ -81,7 +85,7 @@ jobs:
8185
- uses: actions/setup-python@v5
8286
with:
8387
python-version: ${{ matrix.python-version }}
84-
- run: curl -sSL https://install.python-poetry.org | python3 - --version 1.5.1
88+
- run: curl -sSL https://install.python-poetry.org | python3 - --version ${{ env.POETRY_VERSION }}
8589
- run: |
8690
poetry install
8791
poetry run pytest tests/unit
@@ -98,8 +102,8 @@ jobs:
98102
- uses: actions/checkout@v4
99103
- uses: actions/setup-python@v5
100104
with:
101-
python-version: "3.9"
102-
- run: curl -sSL https://install.python-poetry.org | python3 - --version 1.5.1
105+
python-version: ${{ env.PYTHON_VERSION }}
106+
- run: curl -sSL https://install.python-poetry.org | python3 - --version ${{ env.POETRY_VERSION }}
103107
- name: Install Splunk
104108
run: |
105109
export SPLUNK_PRODUCT=splunk
@@ -165,8 +169,8 @@ jobs:
165169
persist-credentials: false
166170
- uses: actions/setup-python@v5
167171
with:
168-
python-version: "3.9"
169-
- run: curl -sSL https://install.python-poetry.org | python3 - --version 1.5.1
172+
python-version: ${{ env.PYTHON_VERSION }}
173+
- run: curl -sSL https://install.python-poetry.org | python3 - --version ${{ env.POETRY_VERSION }}
170174
- run: |
171175
poetry install
172176
poetry build

docs/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ Splunk Solutions SDK is an open source packaged solution for getting data into S
44
This SDK is used by Splunk Add-on builder, and Splunk UCC based add-ons and is intended for use by partner
55
developers. This SDK/Library extends the Splunk SDK for Python.
66

7-
> Note: this project uses `poetry` 2.1.2.
7+
> Note: this project uses `poetry` 1.5.1.

0 commit comments

Comments
 (0)