Fix config stanza reading login in the splunkenv.py#430
Closed
echipachenko wants to merge 1 commit intosplunk:developfrom
echipachenko:develop
Closed
Fix config stanza reading login in the splunkenv.py#430echipachenko wants to merge 1 commit intosplunk:developfrom echipachenko:develop
echipachenko wants to merge 1 commit intosplunk:developfrom
echipachenko:develop
Conversation
Contributor
|
Given the use case and fix, a rather non-breaking fix would be allowing developers to pass their custom scope when getting certain conf file details rather than hard-coding it to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Method get_conf_stanzas internally calls
$SPLUNK_HOME/bin/splunk cmd btool server listThis command leads to accumulated output. It reads
server.conffiles from all apps.Such behaviour may lead to invalid results, if an app has different (not supported) format in the conf file.
I suggest to change login and read configs only from the
systemapp:$SPLUNK_HOME/bin/splunk cmd btool server list --app=system