fix: bump Splunk version#211
Conversation
github-actions
Bot
force-pushed
the
fix/update-splunk-version
branch
from
a100b80 to
2d467cd
Compare
github-actions
Bot
force-pushed
the
fix/update-splunk-version
branch
from
2d467cd to
4751c7f
Compare
github-actions
Bot
force-pushed
the
fix/update-splunk-version
branch
from
4751c7f to
1ddc589
Compare
github-actions
Bot
force-pushed
the
fix/update-splunk-version
branch
from
1ddc589 to
fb49b3d
Compare
github-actions
Bot
force-pushed
the
fix/update-splunk-version
branch
from
fb49b3d to
b9533a0
Compare
github-actions
Bot
force-pushed
the
fix/update-splunk-version
branch
from
b9533a0 to
c23c1e3
Compare
github-actions
Bot
force-pushed
the
fix/update-splunk-version
branch
3 times, most recently
from
3fe54ed to
50ee3cc
Compare
|
@codex please review |
github-actions
Bot
force-pushed
the
fix/update-splunk-version
branch
from
50ee3cc to
58667e3
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50ee3cc31f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| config.set(major_minor, "VERSION", latest_version) | ||
| if build: | ||
| config.set(major_minor, "BUILD", build) | ||
| config.set(major_minor, "SUPPORTED", supported) |
There was a problem hiding this comment.
When get_supported_date() returns UNKNOWN (which it does for network errors, parse misses, and Not Released rows), this writes that literal into splunk_matrix.conf. The action consumer in addonfactory_test_matrix_action/main.py always parses SUPPORTED with datetime.strptime(..., "%Y-%m-%d") before filtering, so any auto-discovered version with an unresolved support date will make the released action fail at startup instead of emitting a matrix. Skip unresolved stanzas or update the consumer before allowing UNKNOWN here.
Useful? React with 👍 / 👎.
| if supported_str == "UNKNOWN": | ||
| continue | ||
| try: | ||
| if datetime.date.fromisoformat(supported_str) < today: |
There was a problem hiding this comment.
The action treats the support date as exclusive (today >= eol causes a stanza to be skipped in addonfactory_test_matrix_action/main.py), but this pruner only removes dates strictly before today. On the exact SUPPORTED date, the updater leaves an already-skipped stanza in the file and update_general_section() can still point LATEST/OLDEST at it; if that stanza is latest, the action emits no latestSplunk output for that day. Align the updater with the consumer by pruning <= today.
Useful? React with 👍 / 👎.
mkolasinski-splunk
force-pushed
the
fix/update-splunk-version
branch
from
58667e3 to
c3734b6
Compare
github-actions
Bot
force-pushed
the
fix/update-splunk-version
branch
from
c3734b6 to
42e5c3b
Compare
|
🎉 This PR is included in version 3.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 participants
No description provided.