Skip to content

refactor: attacker_tools_on_endpoint performance#3589

Merged
patel-bhavin merged 3 commits into
splunk:developfrom
sventec:refactor-attacker_tools_on_endpoint
Jul 7, 2025
Merged

refactor: attacker_tools_on_endpoint performance#3589
patel-bhavin merged 3 commits into
splunk:developfrom
sventec:refactor-attacker_tools_on_endpoint

Conversation

@sventec

@sventec sventec commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

Details

Refactor detection logic for attacker_tools_on_endpoint to improve search performance.

The following line was added to the where clause of the initial tstats command:

[| inputlookup attacker_tools | rename attacker_tool_names AS Processes.process_name | fields Processes.process_name]

This same pattern is in use for detect_remote_access_software_usage_process, see here.

This greatly improves the performance of the detection search when operating over a large dataset.

I'm unsure if there's any other "meta" info that I need to update as part of the PR, please let me know if I missed something. I bumped the detection version, and updated the detection date to today.

Checklist

  • Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
  • CI/CD jobs passed ✔️
  • Validated SPL logic.
  • Validated tags, description, and how to implement.
  • Verified references match analytic.
  • Confirm updates to lookups are handled properly.

Notes For Submitters and Reviewers

  • If you're submitting a PR from a fork, ensuring the box to allow updates from maintainers is checked will help speed up the process of getting it merged.
  • Checking the output of the build CI job when it fails will likely show an error about what is failing. You may have a very descriptive error of the specific field(s) in the specific file(s) that is causing an issue. In some cases, its also possible there is an issue with the YAML. Many of these can be caught with the pre-commit hooks if you set them up. These errors will be less descriptive as to what exactly is wrong, but will give you a column and row position in a specific file where the YAML processing breaks. If you're having trouble with this, feel free to add a comment to your PR tagging one of the maintainers and we'll be happy to help troubleshoot it.
  • Updates to existing lookup files can be tricky, because of how Splunk handles application updates and the differences between existing lookup files being updated vs new lookups. You can read more here but the short version is that any changes to lookup files need to bump the the date and version in the associated YAML file.

refactor attacker_tools_on_endpoint to improve search performance, using
the same paradigm as detect_remote_access_software_usage_process.
@ljstella ljstella added this to the v5.9.0 milestone Jul 3, 2025
@patel-bhavin

patel-bhavin commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

@sventec - Thank you for the updated search and this PR ! This certainly should improve the performance. Feel free to add your name or github handle to the author field example - < sventec, Gitlab Community> .

We will get this update shipped in the next release or so.

App inspect CI check is expected to fail for forks, FYI

@sventec

sventec commented Jul 3, 2025

Copy link
Copy Markdown
Contributor Author

Thanks patel-bhavin! Have updated the author field. Appreciate the note on appinspect as well. Cheers!

@patel-bhavin
patel-bhavin merged commit b39292c into splunk:develop Jul 7, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants