refactor: attacker_tools_on_endpoint performance#3589
Merged
patel-bhavin merged 3 commits intoJul 7, 2025
Conversation
refactor attacker_tools_on_endpoint to improve search performance, using the same paradigm as detect_remote_access_software_usage_process.
Contributor
|
@sventec - Thank you for the updated search and this PR ! This certainly should improve the performance. Feel free to add your name or github handle to the author field example - < sventec, Gitlab Community> . We will get this update shipped in the next release or so. App inspect CI check is expected to fail for forks, FYI |
Contributor
Author
|
Thanks patel-bhavin! Have updated the author field. Appreciate the note on appinspect as well. Cheers! |
patel-bhavin
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Refactor detection logic for attacker_tools_on_endpoint to improve search performance.
The following line was added to the
whereclause of the initialtstatscommand:This same pattern is in use for
detect_remote_access_software_usage_process, see here.This greatly improves the performance of the detection search when operating over a large dataset.
I'm unsure if there's any other "meta" info that I need to update as part of the PR, please let me know if I missed something. I bumped the detection version, and updated the detection date to today.
Checklist
<platform>_<mitre att&ck technique>_<short description>nomenclatureNotes For Submitters and Reviewers
buildCI job when it fails will likely show an error about what is failing. You may have a very descriptive error of the specific field(s) in the specific file(s) that is causing an issue. In some cases, its also possible there is an issue with the YAML. Many of these can be caught with the pre-commit hooks if you set them up. These errors will be less descriptive as to what exactly is wrong, but will give you a column and row position in a specific file where the YAML processing breaks. If you're having trouble with this, feel free to add a comment to your PR tagging one of the maintainers and we'll be happy to help troubleshoot it.