Fix case-sensitive AD self-add group comparison#4112
Conversation
|
Rechecked this branch after the failed CI run. The PR diff is still limited to the intended case-insensitive comparison plus version/date bump, and the detection YAML parses cleanly. Local sanity check passed:
The two failing GitHub Actions jobs appear to be blocked before exercising this detection because forked PR runs do not receive Splunk credentials:
The other checks (YAML Validation, build, and response template build) passed. |
|
@srkyn - thank you for the PR and doing the testing locally, I think the fix makes sense and I will raise this issue of unit-testing needing creds. We recently updated our tooling and didnt think of this issue coming up! I will get back to you! |
|
Thanks, that makes sense. I will leave the branch as-is unless you want a change from my side. The detection diff is intentionally small: case-insensitive comparison only, plus version/date metadata. |
77d14ed to
57f0fca
Compare
Summary
Fixes the
Windows AD add Self to Groupanalytic so the self-add comparison is case-insensitive:Why
Issue #4105 reports that matching can fail when the same account appears with different casing, for example
user=DA-1andsrc_user=da-1.Validation
Result:
Fixes #4105.