Conversation
nasbench
requested review from
P4T12ICK,
RavenTait,
ljstella,
patel-bhavin,
pyth0n1c,
rosplk and
tccontre
as code owners
July 28, 2026 18:35
There was a problem hiding this comment.
Pull request overview
This PR makes small adjustments to two endpoint detection YAMLs: one aligns detection text with what the search actually covers, and the other changes the exclusion list used to reduce noise/processing in a ransomware-extension analytic.
Changes:
- Updated the description text in the “Windows File Without Extension In Critical Folder” detection.
- Modified the
NOT Filesystem.file_name IN (...)extension exclusion list for the “Common Ransomware Extensions” detection (removing*.zip).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| detections/endpoint/windows_file_without_extension_in_critical_folder.yml | Tweaks the description text for the detection. |
| detections/endpoint/common_ransomware_extensions.yml | Alters the extension exclusion list used to pre-filter common file activity. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pyth0n1c
approved these changes
Jul 28, 2026
pyth0n1c
left a comment
pyth0n1c
left a comment
Collaborator
There was a problem hiding this comment.
Since this is a description update and a brief additive search update, I am comfortable approving this even though unit testing has not finished yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor fixes